-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating ruff precommit #1473
Merged
DhanshreeA
merged 55 commits into
ersilia-os:master
from
Abellegese:chore/integrate-ruff-precommit
Jan 3, 2025
Merged
Integrating ruff precommit #1473
DhanshreeA
merged 55 commits into
ersilia-os:master
from
Abellegese:chore/integrate-ruff-precommit
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Abellegese could you please resolve conflicts here? |
Yes @DhanshreeA I will. |
* added new categories * added try-except * bugfix list to dictionary * added output consistency field and blackened code * Update columns_information.py
fcf4287
to
1cce2f9
Compare
* Modify header calculation to choose from predefined example output file or standard example output file * Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function * Remove unused method * Make csv serialization work for any kind of model api response * Remove the standard flag from the CLI since it is now the default run * Update tests
* Merge sample command with the example command * Fix example command usage
* Modify header calculation to choose from predefined example output file or standard example output file * Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function * Remove unused method * Make csv serialization work for any kind of model api response * Remove the standard flag from the CLI since it is now the default run * Update tests
* Modify header calculation to choose from predefined example output file or standard example output file * Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function * Remove unused method * Make csv serialization work for any kind of model api response * Remove the standard flag from the CLI since it is now the default run * Update tests
f173a24
to
1c9f136
Compare
68e3798
to
6a2b96a
Compare
a3192f1
to
349cb4e
Compare
DhanshreeA
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Refactoring Overview
This PR integrate ruff and precommit-hook based linting. Also refactors the codebase to comply with the specified
ruff
linting and formatting rules. Below is a checklist of the key changes made:Line Length: Updated to a maximum of 88 characters for better readability.
Indentation: Standardized indentation width to 4 spaces.
Target Python Version: Refactored code to align with Python 3.10 features and standards.
Selected Rules: Enabled checks for:
Ignored Rules: Excluded:
Fixable Rules: Applied automated fixes for all applicable rules.
Dummy Variables: Standardized naming for unused variables with the regex
^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$
.Docstring Style: Adopted NumPy-style docstrings for consistency.
Formatting: Ensured:
Results
Related to #1417