change minimum length for description to 10 #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miquelduranfrigola I don't understand why we want to do this though? Isn't 10 words too short for a description? |
|
Not really, @DhanshreeA. This is for the columns description, not the model description. Columns like "molecular_weight" can be described as "Molecular weight in g/mol" and this is it. 60 characters was way too long for some of the simple columns. |
DhanshreeA
added a commit
that referenced
this pull request
Jan 14, 2025
Co-authored-by: Dhanshree Arora <DhanshreeA@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have simply changed the minimum description length for the columns
Related to issue for model eos4djh