Skip to content

Commit

Permalink
feat: remove 'legacy' parameter
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The legacy protocol support was removed from Cloud SDK 267.0.0
  • Loading branch information
ert78gb committed Nov 14, 2019
1 parent e72fe09 commit 80d1c7e
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 15 deletions.
7 changes: 0 additions & 7 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ interface Options {
*/
debug?: boolean;

/**
* Default: false
*
* If it is true, it supports Cloud Datastore API v1beta2.
*/
legacy?: boolean;

/**
* Default: '1.0'
*
Expand Down
2 changes: 0 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ describe('test suit', ()=>{

before(()=>{
const options = {
legacy: true, // if you need legacy support
useDocker: true // if you need docker image
};

Expand Down Expand Up @@ -67,7 +66,6 @@ clean (boolean) | true | If dataDir value is set and 'clean' value is true then
host (string) | localhost | If it is empty the'localhost' of google default value is used. It can take the form of a single address (hostname, IPv4, or IPv6)
port (number) | 8081 | If it is empty the emulator selects a random free port. If use docker version always set port.
debug (boolean) | false | If it is true, it writes the console.logs of the emulator onto the main process console.
legacy (boolean) | false | If it is true, it supports Cloud Datastore API v1beta2.
consistency (string) | '1.0' | The consistency level of the Datastore Emulator. [More details](https://cloud.google.com/sdk/gcloud/reference/beta/emulators/datastore/start)
useDocker (boolean) | false | If it is true, it use docker image to run emulator instead of locally installed version.
dockerImage (string) | 'google/cloud-sdk:latest' | This image will be use by docker. The default: [google/cloud-sdk:latest](https://hub.docker.com/r/google/cloud-sdk/)
Expand Down
5 changes: 0 additions & 5 deletions src/base-emulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,6 @@ class BaseEmulator {
params.push('--no-store-on-disk')
}

if (this._options.legacy) {
console.warn('"legacy" parameter is deprecated by Google. It will be removed in early October 2019')
params.push('--legacy')
}

this._setConsistency(params);

return params;
Expand Down
1 change: 0 additions & 1 deletion src/datastore-emulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const DEFAULT_OPTIONS = {
storeOnDisk: false,
legacy: false,
clean: true,
debug: false,
useDocker: false,
Expand Down

0 comments on commit 80d1c7e

Please sign in to comment.