Skip to content

Commit

Permalink
Fixup typo where an extra copy of AIRFuseChannels pass was applied
Browse files Browse the repository at this point in the history
  • Loading branch information
erwei-xilinx committed Oct 23, 2024
1 parent c11700a commit bea71d6
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/Passes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -746,15 +746,6 @@ void addMLIRAIRLoweringPasses(OpPassManager &passManager, AMDAIEDevice device,
passManager.addPass(xilinx::air::createAIRIsolateAsyncDmaLoopNests());
passManager.addPass(createCanonicalizerPass());
passManager.addPass(createCSEPass());
{
xilinx::air::AIRFuseChannelsOptions options;
if (useTilePipeline == TilePassPipeline::PackPeelPipeline &&
matmulElementwiseFusion) {
const static llvm::SmallVector<std::string> mode = {"L1"};
options.clAggressiveMode = mode;
}
passManager.addPass(xilinx::air::createAIRFuseChannels(options));
}
passManager.addPass(createCanonicalizerPass());
passManager.addPass(createCSEPass());
passManager.addNestedPass<func::FuncOp>(
Expand Down Expand Up @@ -818,12 +809,10 @@ void addMLIRAIRLoweringPasses(OpPassManager &passManager, AMDAIEDevice device,
// with given factors, and subsequently unrolled in
// AIRUnrollOuterPerfectlyNestedLoopsPass, to enforce SHIM DMA BD count
// within the hardware limit.
if (useTilePipeline == TilePassPipeline::PackPeelPipeline &&
matmulElementwiseFusion) {
if (useTilePipeline == TilePassPipeline::PackPeelPipeline) {
const static llvm::SmallVector<unsigned> tile_sizes = {2, 2};
options.clTileSizes = tile_sizes;
} else if (useTilePipeline == TilePassPipeline::PadPackPipeline ||
useTilePipeline == TilePassPipeline::PackPeelPipeline) {
} else if (useTilePipeline == TilePassPipeline::PadPackPipeline) {
const static llvm::SmallVector<unsigned> tile_sizes = {4, 4};
options.clTileSizes = tile_sizes;
}
Expand Down

0 comments on commit bea71d6

Please sign in to comment.