Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional terminals #144

Closed
nicolo-ribaudo opened this issue May 10, 2023 · 3 comments
Closed

Support optional terminals #144

nicolo-ribaudo opened this issue May 10, 2023 · 3 comments
Assignees
@jhnaldo
Labels
bug Something isn't working new feature Implements a new feature

Comments

@nicolo-ribaudo
Copy link

Example:

NonTerminal : 
  `a` `b`?

Terminal symbols can be optional, according to https://tc39.es/ecma262/#sec-optional-symbols.

Ref tc39/ecma262#3057 (comment)
@jhnaldo jhnaldo self-assigned this May 11, 2023
@jhnaldo
Copy link
Contributor

jhnaldo commented May 11, 2023

Hi, @nicolo-ribaudo. Thanks for your issue! I will try to address it as soon as I can.

@jhnaldo jhnaldo added bug Something isn't working new feature Implements a new feature labels May 11, 2023
jhnaldo added a commit that referenced this issue May 18, 2023
@jhnaldo
Support optional for all symbols (#144)
503b2fa
jhnaldo added a commit that referenced this issue May 18, 2023
@jhnaldo
Support optional for all symbols (#144)
fea4001
@jhnaldo jhnaldo mentioned this issue May 21, 2023
Merged
@jhnaldo
Copy link
Contributor

jhnaldo commented May 21, 2023

Dear @nicolo-ribaudo, I resolved this issue at 503b2fa. So, I closed this issue.

@jhnaldo jhnaldo closed this as completed May 21, 2023
@nicolo-ribaudo
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhnaldo jhnaldo

Labels
bug Something isn't working new feature Implements a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhnaldo @nicolo-ribaudo