Object.keys doesn't work correctly with string objects.

[jdalton]

See http://jsbin.com/xijifore/1.
In IE8 it will alert 0 instead of 5.

alert(Object.keys(Object("hello")).length);

[jdalton]

I don't believe this issue was addressed.

[ljharb]

I wasn't able to reproduce your issue in object-keys, and adding arguments detection makes the implementations identical. Can you still reproduce the String issue in es5-shim, and in object-keys? I'll reopen just in case.

[jdalton]

Before your patch es5-shim:

Can you still reproduce the String issue in es5-shim, and in object-keys?

After your patch es5-shim it throws an error in IE8 (mentioned in the commit comments).

[ljharb]

Cool, thanks for reporting, I'll take a look.

[jdalton]

On 94e0add

var a = Object('x');
a.y = 1;
Object.keys(a);
// should be ["0", "y"]

currently it will only be ["0"]

[ljharb]

This is a tricky one :-) thanks, will keep looking.

[hazzik]

I think you just need to remove else keyword?

[jdalton]

@ljharb
I fixed this in Lo-Dash before reporting it here.
For reference see the compat build (you can ignore the array checks as we treat all arrays as dense).

[ljharb]

This final edge case still fails in Firefox, but should pass everywhere else. I'm leaning towards this holding up a v3.0 build - since we're now overriding more native methods, it's worth a major version bump imo. Hopefully I'll have time to finish it up this weekend.

[ljharb]

Actually this is now fixed. Please open a new issue if you find more issues with Object.keys :-) thanks!