Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 Array#splice tests failing in IE 8 #341

Open
ljharb opened this issue Nov 8, 2015 · 1 comment
Open

3 Array#splice tests failing in IE 8 #341

ljharb opened this issue Nov 8, 2015 · 1 comment
Assignees

Comments

@ljharb
Copy link
Member

ljharb commented Nov 8, 2015

These tests pass just fine in IE 6 and 7.

Relates to #114.

@ljharb ljharb self-assigned this Nov 8, 2015
@Xotic750
Copy link
Contributor

This was one persons study and conclusions.
https://social.msdn.microsoft.com/Forums/ie/en-US/6e946d03-e09f-4b22-a4dd-cd5e276bf05a/splice-function-in-ie8-is-broken?forum=iewebdevelopment

Also, IE <9 has a bug/difference where the second argument is required rather than optional. I don't think you have any tests for this?

var array = [0, 1, 2];
array.splice(0);
alert(array);

http://stackoverflow.com/questions/8332969/ie-8-splice-not-working

So, it looks like 2 tests and fixes.

IE8 should just use the full replacement, I don't think you can do a partial reasonably?

IE<8 requires a partial for the second argument, when it is not supplied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants