Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make regularization loss weight a cfg parameter #17

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Make regularization loss weight a cfg parameter #17

merged 1 commit into from
Aug 24, 2021

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Aug 24, 2021

Description

  • Fixed alignment in print_cfg
  • Added reg_loss_weight as parameter in cfg

How Has This Been Tested?

  • Ran training NB and changed values

@gomezzz
- Fixed alignment in print_cfg
7378819 
- Added reg_loss_weight as parameter in cfg
@gomezzz gomezzz requested a review from htoftevaag August 24, 2021 10:03
@gomezzz gomezzz mentioned this pull request Aug 24, 2021
Merged
htoftevaag
htoftevaag approved these changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking goood

@htoftevaag htoftevaag merged commit 3ba3a0d into main Aug 24, 2021
@htoftevaag htoftevaag deleted the Make-regularization-loss-weight-a-cfg-parameter branch August 24, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htoftevaag htoftevaag htoftevaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomezzz @htoftevaag