Fix material matching plot (try plotting ground truth and see if right material comes out) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Small fix in find_closest_material - Cleaned up some imports - Added plot to training NB
…und-truth-and-see-if-right-material-comes-out)
htoftevaag
approved these changes
Aug 25, 2021
nidn/materials/layer_builder.py
Outdated
|
|
||
| class LayerBuilder: | ||
| def __init__(self, run_cfg) -> None: | ||
| """Initializes the builder |
There was a problem hiding this comment.
Suggested change
| """Initializes the builder | |
| """Initializes the builder. |
nidn/materials/layer_builder.py
Outdated
| """Initializes the builder | ||
|
|
||
| Args: | ||
| run_cfg (DotMap): Run configuration |
There was a problem hiding this comment.
Suggested change
| run_cfg (DotMap): Run configuration | |
| run_cfg (DotMap): Run configuration. |
nidn/materials/layer_builder.py
Outdated
| self.material_collection = MaterialCollection(self.run_cfg.target_frequencies) | ||
|
|
||
| def _setup_grid_and_materials(self,): | ||
| """Utility function to setup essentials |
There was a problem hiding this comment.
Suggested change
| """Utility function to setup essentials | |
| """Utility function to setup essentials. |
htoftevaag
requested changes
Aug 25, 2021
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
htoftevaag
approved these changes
Aug 25, 2021
htoftevaag
deleted the
Fix-material-matching-plot-(try-plotting-ground-truth-and-see-if-right-material-comes-out)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First merge #15
How Has This Been Tested?
Plots look like this