Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target spectrum to config #27

Merged
merged 6 commits into from
Aug 25, 2021
Merged

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Aug 25, 2021

Description

First merge #25

  • Moved target spectrum into cfg
  • Minor refactoring
  • Adapted training notebook

How Has This Been Tested?

  • Training NB

Related Pull Requests

Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested changes. You might have to change my suggestions

nidn/training/run_training.py Outdated Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, see comments 😝

gomezzz and others added 3 commits August 25, 2021 14:26
@gomezzz gomezzz requested a review from htoftevaag August 25, 2021 12:27
@htoftevaag htoftevaag merged commit 53d3889 into main Aug 25, 2021
@htoftevaag htoftevaag deleted the Add-target-spectrum-to-config branch August 25, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants