Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example notebooks for FDTD, one how to use on its own, and one … #78

Merged
merged 11 commits into from
Apr 22, 2022

Conversation

torbjornstoro
Copy link
Collaborator

…with use with nidn

Description

Summary of changes

  • ...
  • ...

Resolved Issues

  • fixes #Issue

How Has This Been Tested?

  • Test A
  • Test B

Related Pull Requests

  • #PR

@torbjornstoro torbjornstoro requested a review from gomezzz April 19, 2022 14:58
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FDTD training notebook does not even use FDTD. More in comments

notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
@torbjornstoro torbjornstoro requested a review from gomezzz April 21, 2022 08:38
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
@torbjornstoro torbjornstoro requested a review from gomezzz April 21, 2022 14:54
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal changes, feel free to merge after fixing them

notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/FDTD_Training.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
notebooks/Running_FDTD.ipynb Outdated Show resolved Hide resolved
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
@torbjornstoro torbjornstoro merged commit f0ec337 into waveregime-internship Apr 22, 2022
@torbjornstoro torbjornstoro deleted the WI_notebook_examples branch April 22, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants