Added notebook for generating NIDN results using FDTD #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomezzz
requested changes
Apr 26, 2022
gomezzz
requested changes
Apr 28, 2022
| "cfg.solver = \"FDTD\"\n", | ||
| "cfg.FDTD_niter = 400\n", | ||
| "cfg.N_layers = 1\n", | ||
| "cfg.FDTD_pulse_type = 'continuous'\n", | ||
| "cfg.FDTD_source_type = 'line'\n", | ||
| "\n", | ||
| "# Currently, the target spectra is set manually as a list of numbers \n", | ||
| "cfg.target_reflectance_spectrum = [0.04456351,0.12983103,0.20803709,0.34838794,0.40374041,0.43852469,0.42395525,0.35184451,0.23594347,0.09928435,0.04685543,0.05025798,0.16480385,0.34852490,0.47360640,0.48079059,0.47393927,0.32548627,0.30220670,0.06996665,0.06193323,0.28238744,0.32690241,0.53719555,0.54476352,0.35588386,0.29008964,0.18691291,0.27902207,0.35943538,0.57196896,0.52884206,0.44624134,0.36921438,0.51291333,0.59620698,0.26694859,0.44032823,0.49345384,0.45239907,0.51884675,0.54193479,0.56739480,0.57878280,0.65530901,0.64809091,0.63580893,0.62772046,0.66017392,0.64911847,]\n", |
There was a problem hiding this comment.
Can we change the Ground-truth Data Generation notebook to use 100 instead of 20 points? Then these points should be exactly every 5th frequency point, right? Otherwise it is not clear where this ground truth comes from
There was a problem hiding this comment.
Okay, but didnt we agree on Tuesday to decrease it from 50 to 20 frequencies due to runtime?
There was a problem hiding this comment.
Yes, keep it at 20 here, but in the other notebook make it 100? So that the 20 points in this notebook are part of the 100 in the other to see that values match?
| @@ -195,7 +195,7 @@ | |||
| "cfg.Nx = 1\n", | |||
| "cfg.Ny = 1\n", | |||
| "cfg.N_layers = 3\n", | |||
| "cfg.N_freq = 32\n", | |||
There was a problem hiding this comment.
please also change ground truth in supplementary notebook to match this, numbers shoudl be the same then
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
As title