-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): add customization API for IntegrationGrid
#173
Conversation
@ilan-gold So, to make sure I remember correctly: This allows integrating multiple integrands on different domains by transforming each integral into [0,1], right? If so:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller comments
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a minor comment, looks good :) 👍
Description
Focused on customizing the integration domain, this PR allows the user to turn off checks for the domain and also gives a bit more freedom to the
grid_func
to not have to deal only witha
andb
in[a,b]
but rather just takes is[a,b]
.Summary of changes
disable_integration_domain_check
argument where applicablea
andb
to justintegration_domain
How Has This Been Tested?