Add "wrap" to exports. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,9 @@ | |||
| var _ = require('underscore'); | |||
| var deepEqual = require('assert').deepEqual; | |||
| var s = require('../dist/underscore.string'); | |||
There was a problem hiding this comment.
could you change this to
- var s = require('../dist/underscore.string');
+ var s = require('../');otherwise this looks good.
|
btw. to run the tests locally you can just run |
added 2 commits
February 20, 2016 09:33
Fixes a bug introduced in esamattis#410.
|
@stoeffel I made the change you requested (also changed a usage of double quotes to single quotes, as it appears that you are standardizing on single quotes) and squashed the commit. Thanks for pushing out a release so quickly! I took a look at #481 and #482, but don't really have the background to review them. |
|
finally published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stoeffel Here is my PR to fix the exports function.