Init file structure #4
Conversation
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "presets": ["react", "es2015", "stage-0"], | |||
There was a problem hiding this comment.
stage-0
What ES7 features do you want to use? I think it's better to name those and include those.
There was a problem hiding this comment.
Not pretty sure for now.
And .. I can't understand 'I think it's better to name those and include those.'.
It's mean that I only get what I need?
There was a problem hiding this comment.
It's mean that I only get what I need?
Yes, let's what I mean. Since you don't know what you want to use now. Do you think it's a good idea to add when you want it?
There was a problem hiding this comment.
okay ... I remove it.
haha .. i find a typo ... from me (know / new 囧rz)
|
I'm curious. Do you order |
| @@ -0,0 +1,6 @@ | |||
| // import { fork } from 'redux-saga/effects'; | |||
|
|
|||
| export default function* root() { | |||
There was a problem hiding this comment.
I just found that there is import rootSaga from './Root/rootSaga'; in the src/index.js file. Do you think it'd be a good idea to rename root to rootSaga?
| }) | ||
| ], | ||
|
|
||
| }; |
There was a problem hiding this comment.
Through out this file, some loaders are used with the -loader suffix while some aren't. Do you think it's a good idea to make a decision to always use the -loader suffix or never use the -loader suffix?
|
In webpack.config.js, |
| contentBase: './dist', | ||
| port: PORT, | ||
| hot: true, | ||
| }, |
There was a problem hiding this comment.
Do you think it'd be a good idea to move all CLI switches in npm start to be under this devServer property?
| template: './src/index.html', | ||
| }), | ||
| ] | ||
| }; |
There was a problem hiding this comment.
Do you want to fix this file?
|
Hi @esbb48 , I just finished commenting. Please review. Thanks. I saw a lot of done. But I didn't see any follow up commits on this branch. Do you forgot to push them? Thanks. |
|
HI @sharils, Because I push wrong branch .... |
| "babel-plugin-transform-object-rest-spread": "^6.8.0", | ||
| "babel-preset-es2015": "^6.9.0", | ||
| "babel-preset-react": "^6.11.1", | ||
| "babel-preset-stage-0": "^6.5.0", |
There was a problem hiding this comment.
Did you forget to remove "babel-preset-stage-0": "^6.5.0" ? :)
|
LGTM except for my last comment. Cheers! :) |
Ticket :: #2 Initial the file structure.