Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esbuild-plugin-pipe #13

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add esbuild-plugin-pipe #13

merged 2 commits into from
Jan 27, 2021

Conversation

hum-n
Copy link
Contributor

@hum-n hum-n commented Jan 20, 2021

Hey @evanw,

Did you have any plans to support something like this? In the meantime, I think this can be useful. It is for me.
Please tell me if you have any feedback on it. If not, I'll publish two other plugins that support it.

https://github.com/nativew/esbuild-plugin-pipe

Thanks ✌️

@evanw
Copy link
Contributor

evanw commented Jan 26, 2021

Interesting idea. I think this may eventually be possible to do natively using something like evanw/esbuild#647. It's a valid work-around in the meantime though.

One point of feedback: I think it'd be best if you changed this plugin so that the call signature is more extensible. Something like setup(build, {transform} = {}) { instead of setup(build, transform) {. That way other plugins can add additional meta-features like this without all of them colliding and/or depending on argument ordering. What do you think?

@hum-n
Copy link
Contributor Author

hum-n commented Jan 26, 2021

Yes, totally, I agree. I did exactly that in the latest version of the package. It's updated. Thanks!

@evanw
Copy link
Contributor

evanw commented Jan 27, 2021

Cool. Thanks for the change.

@evanw evanw merged commit 698da5c into esbuild:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants