Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/patch user api #3

Merged
merged 12 commits into from
Dec 26, 2023
Merged

Feature/patch user api #3

merged 12 commits into from
Dec 26, 2023

Conversation

bblueberries
Copy link
Contributor

Change made

  • Bug fixes
  • New features
  • Breaking changes

Describe what you have done

  • create endpoint , controller, usecases for the APIs and fix UpdateColumn func in package repository

New Features

  • API for patching user_name and is_user_completed

Fix

  • fix UpdateColumn func in package repository to retrieve all fields from the updated row

Others

xappyyy
xappyyy previously requested changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@xappyyy xappyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small bug.

@xappyyy xappyyy self-requested a review December 25, 2023 20:58
@xappyyy xappyyy mentioned this pull request Dec 25, 2023
Closed
@xappyyy xappyyy dismissed their stale review December 25, 2023 21:05

I forgot to put requested lines.

xappyyy
xappyyy requested changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@xappyyy xappyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the changes.

src/domain/user.go Outdated Show resolved Hide resolved
src/domain/user.go Outdated Show resolved Hide resolved
src/usecase/user_usecase.go Outdated Show resolved Hide resolved
src/usecase/user_usecase.go Outdated Show resolved Hide resolved
@xappyyy xappyyy merged commit 5b4e405 into dev Dec 26, 2023
1 check passed
@xappyyy xappyyy deleted the feature/patch-user-api branch December 26, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xappyyy xappyyy xappyyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bblueberries @xappyyy