Revert "Topic cards revised to show three articles (mozilla#6471)"

This reverts commit 01b2e16.
escattone · Feb 6, 2025 · 6240710 · 6240710
1 parent 87c516d
commit 6240710
Show file tree

Hide file tree

Showing 7 changed files with 65 additions and 271 deletions.
diff --git a/kitsune/products/jinja2/products/includes/topic_macros.html b/kitsune/products/jinja2/products/includes/topic_macros.html
@@ -1,45 +1,32 @@
 {% macro help_topics(topics, product_slug=None, new_tab=False) -%}
-{# topics: List of topic_data dicts containing:
-    - topic: Topic model instance
-    - topic_url: URL to topic page
-    - title: Topic title
-    - total_articles: Number of articles
-    - image_url: URL to topic icon
-    - documents: three documents for the topic
-#}
-<div class="topics-section">
-  <div class="topics-grid">
-    {% for topic_data in topics %}
-    <div class="card--topic">
-      <div class="topic-header">
+  <div class="sumo-card-grid">
+    <div class="scroll-wrap">
+      {% for topic in topics %}
+      {% set topic_url = url('products.documents', product_slug=product_slug or product.slug, topic_slug=topic.slug) %}
+      <div class="card card--topic">
         <img
           class="card--icon"
-          src="{{ topic_data.image_url }}"
-          alt="{{ pgettext('DB: products.Topic.title', topic_data.title) }} icon"
+          src="{{ topic.image_url }}"
+          alt="{{ pgettext('DB: products.Topic.title', topic.title) }} icon"
         />
+        <div class="card--details">
           <h3 class="card--title">
-            <a href="{{ topic_data.topic_url }}">
-              {{ pgettext('DB: products.Topic.title', topic_data.title) }}
+            <a class="expand-this-link" href="{{ topic_url }}" data-on-hover="{{ _('See all') }}" {% if new_tab %} target="_blank" {% endif %}
+              data-event-name="link_click"
+              data-event-parameters='{
+                "link_name": "product-and-topic-home",
+                "link_detail": "{{ (product_slug or product.slug) + '/' + topic.slug }}"
+              }'>
+              {{ pgettext('DB: products.Topic.title', topic.title) }}
             </a>
           </h3>
+        </div>
       </div>
-      <ul class="article-list">
-        {% for document in topic_data.documents %}
-        <li>
-          <a href="{{ document.get_absolute_url() }}">      
-            {{ document.title }}</a>
-        </li>
-        {% endfor %}
-      </ul>
-      <a class="view-all-link" href="{{ topic_data.topic_url }}">View All {{ topic_data.total_articles }} Articles</a>
+      {% endfor %}
     </div>
-    {% endfor %}
   </div>
-</div>
 {%- endmacro %}
 
-
-
 {% macro topic_metadata(topics, product=None) %}
 {% if product and has_aaq_config and not settings.READ_ONLY %}
   <section class="support-callouts mzp-l-content sumo-page-section--inner">

diff --git a/kitsune/products/jinja2/products/product.html b/kitsune/products/jinja2/products/product.html
@@ -123,7 +123,7 @@ <h1 class="sumo-page-heading-xl">
     <div class="sumo-page-subheader">
       <div class="sumo-page-subheader--text">
         <div class="text-center-to-left-on-large">
-          <h2 class="sumo-page-subheading">{{ _('Topics') }}</h2>
+          <h2 class="sumo-page-subheading">{{ _('Frequent Topics') }}</h2>
           <p class="sumo-page-intro">{{ _('Explore the knowledge base.') }}</p>
         </div>
       </div>

diff --git a/kitsune/products/views.py b/kitsune/products/views.py
@@ -2,7 +2,7 @@
 
 from django.conf import settings
 from django.db.models import Exists, OuterRef, Q
-from django.http import Http404, HttpRequest, HttpResponse
+from django.http import Http404, HttpResponse
 from django.shortcuts import get_object_or_404, redirect, render
 from product_details import product_details
 
@@ -11,7 +11,7 @@
 from kitsune.wiki.decorators import check_simple_wiki_locale
 from kitsune.wiki.facets import documents_for, topics_for
 from kitsune.wiki.models import Document, Revision
-from kitsune.wiki.utils import build_topics_data, get_featured_articles
+from kitsune.wiki.utils import get_featured_articles
 
 
 @check_simple_wiki_locale
@@ -23,19 +23,8 @@ def product_list(request):
 
 
 @check_simple_wiki_locale
-def product_landing(request: HttpRequest, slug: str) -> HttpResponse:
-    """The product landing page.
-
-    Args:
-        request: The HTTP request
-        slug: Product slug identifier
-
-    Returns:
-        Rendered product landing page
-
-    Raises:
-        Http404: If product not found
-    """
+def product_landing(request, slug):
+    """The product landing page."""
     if slug == "firefox-accounts":
         return redirect(product_landing, slug="mozilla-account", permanent=True)
 
@@ -56,15 +45,14 @@ def product_landing(request: HttpRequest, slug: str) -> HttpResponse:
             latest_version = versions[0].min_version
         else:
             latest_version = 0
-    topics = topics_for(request.user, product=product, parent=None)
 
     return render(
         request,
         "products/product.html",
         {
             "product": product,
             "products": Product.active.filter(visible=True),
-            "topics": build_topics_data(request, product, topics),
+            "topics": topics_for(request.user, product=product, parent=None),
             "search_params": {"product": slug},
             "latest_version": latest_version,
             "featured": get_featured_articles(product, locale=request.LANGUAGE_CODE),

diff --git a/kitsune/questions/views.py b/kitsune/questions/views.py
@@ -70,7 +70,6 @@
 from kitsune.upload.models import ImageAttachment
 from kitsune.users.models import Setting
 from kitsune.wiki.facets import topics_for
-from kitsune.wiki.utils import build_topics_data
 
 log = logging.getLogger("k.questions")
 
@@ -569,10 +568,8 @@ def aaq(request, product_slug=None, step=1, is_loginless=False):
         context["ga_products"] = f"/{product_slug}/"
 
     if step == 2:
-        topics = topics_for(request.user, product, parent=None)
-
         context["featured"] = get_featured_articles(product, locale=request.LANGUAGE_CODE)
-        context["topics"] = build_topics_data(request, product, topics)
+        context["topics"] = topics_for(request.user, product, parent=None)
 
     elif step == 3:
         context["cancel_url"] = get_next_url(request) or (

diff --git a/kitsune/sumo/static/sumo/scss/components/_card.scss b/kitsune/sumo/static/sumo/scss/components/_card.scss
@@ -181,79 +181,21 @@
   }
 
   &--topic {
+    @include c.elevation-01;
     display: flex;
-    flex-direction: column;
-    justify-content: space-between;
-    height: 100%;
-    background-color: p.$color-white;
-    border: 1px solid #ddd;
-    border-radius: p.$border-radius-md;
-    padding: p.$spacing-md;
-    box-shadow: p.$box-shadow-sm;
-    box-sizing: border-box;
-
-    .topic-header {
-      display: flex;
-      align-items: flex-start;
-      gap: 10px;
-      margin-bottom: p.$spacing-md;
-    }
-
-    .card--icon {
-      flex-shrink: 0;
-      width: 18px;
-      height: 18px;
-    }
+    align-items: center;
 
-    .card--title {
-      font-family: Inter;
-      font-size: 16px;
-      font-weight: 700;
+    .card-title {
       margin: 0;
-      line-height: 1.2;
-      flex-grow: 1;
     }
 
-    .article-list {
-      flex-grow: 1;
-      margin: 0 0 p.$spacing-md;
-      padding: 0;
-      list-style: none;
-
-      li {
-        margin-bottom: 8px;
-        line-height: 1.5;
-
-        a {
-          color: black;
-          font-size: 14px;
-          text-decoration: underline;
-          display: -webkit-box;
-          -webkit-line-clamp: 2;
-          line-clamp: 2;
-          -webkit-box-orient: vertical;
-          overflow: hidden;
-
-          &:hover {
-            text-decoration: underline;
-          }
-        }
-      }
-    }
-
-    .view-all-link {
-      border-top: 1px solid #ddd;
-      padding-top: 10px;
-      margin-top: p.$spacing-md;
-      display: inline-block;
-      font-size: 14px;
-      color: #000000;
-      text-decoration: underline;
-      font-weight: normal;
-
-      &:hover {
-        text-decoration: underline;
-      }
+    .card--icon {
+      width: p.$spacing-lg;
+      height: p.$spacing-lg;
+      object-fit: contain;
+      font-size: 9px;
+      line-height: 1;
+      flex: 0 0 auto;
     }
   }
 

diff --git a/kitsune/sumo/static/sumo/scss/layout/_products.scss b/kitsune/sumo/static/sumo/scss/layout/_products.scss
@@ -1,6 +1,7 @@
 @use '../config' as c;
 @use 'protocol/css/includes/lib' as p;
 
+
 .sumo-page-subheader {
   display: flex;
   flex-direction: column-reverse;
@@ -31,51 +32,3 @@
     margin: 0 p.$spacing-xs;
   }
 }
-
-.topics-section {
-  padding: 40px 20px;
-  h2 {
-    font-size: 24px;
-    margin-bottom: 0px;
-    color: #333;
-  }
-
-  @media #{p.$mq-sm} {
-    padding: p.$spacing-lg p.$spacing-md;
-  }
-}
-
-.topics-grid {
-  @media #{p.$mq-lg} {
-    display: grid;
-    grid-template-columns: repeat(3, 1fr);
-    gap: 20px;
-  }
-
-  @media (max-width: #{p.$screen-lg}) {
-    display: flex;
-    overflow-x: auto;
-    gap: p.$spacing-md;
-    padding: p.$spacing-md 0;
-    scroll-snap-type: x mandatory;
-    -webkit-overflow-scrolling: touch;
-    scrollbar-width: none;
-
-    &::-webkit-scrollbar {
-      display: none;
-    }
-
-    > .card--topic {
-      flex: 0 0 280px;
-      height: 280px;
-      scroll-snap-align: start;
-      display: flex;
-      flex-direction: column;
-      overflow: hidden;
-
-      > * {
-        flex-shrink: 0;
-      }
-    }
-  }
-}