-
Notifications
You must be signed in to change notification settings - Fork 1
Align StyleCop.Analyzers package version declaration across project files #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the central package management configuration by adding a specific version for "StyleCop.Analyzers.Unstable" in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/Escendit.Tools.CodeAnalysis.StyleCopAnalyzers/Escendit.Tools.CodeAnalysis.StyleCopAnalyzers.csproj (1)
12-15: Confirm intended transitivity of analyzersCurrent settings allow analyzers to flow transitively (PrivateAssets excludes analyzers; IncludeAssets includes analyzers; buildtransitive). If you intend to prevent transitive exposure and control it only via your buildTransitive assets, change to PrivateAssets="all". Otherwise, keep as-is.
Possible adjustment if you want to avoid transitive analyzer leakage:
- <PackageReference Include="StyleCop.Analyzers.Unstable"> - <PrivateAssets>runtime; build; native; contentfiles</PrivateAssets> - <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> - </PackageReference> + <PackageReference Include="StyleCop.Analyzers.Unstable"> + <PrivateAssets>all</PrivateAssets> + <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> + </PackageReference>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Directory.Packages.props(1 hunks)src/Escendit.Tools.CodeAnalysis.StyleCopAnalyzers/Escendit.Tools.CodeAnalysis.StyleCopAnalyzers.csproj(1 hunks)
🔇 Additional comments (2)
Directory.Packages.props (1)
4-4: Centralized version pin added — LGTMAdding StyleCop.Analyzers.Unstable 1.2.0.556 to Directory.Packages.props aligns with CPM and the PR objective to consolidate versions.
src/Escendit.Tools.CodeAnalysis.StyleCopAnalyzers/Escendit.Tools.CodeAnalysis.StyleCopAnalyzers.csproj (1)
12-15: Switched to central package version — LGTMRemoving the Version attribute here correctly defers resolution to Directory.Packages.props.
Closes #32
Summary by CodeRabbit