Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update with_aux to include_auxdata in pyhf v0.6.3+ API #13

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

kratsg
Copy link
Collaborator

@kratsg kratsg commented Nov 8, 2021

See scikit-hep/pyhf#1562 . This makes simplify compatible with more recent pyhf versions.

* Set minimum required pyhf version to v0.6.3
   - Set lower bound on pyhf instead of pinning
* Update API to be compatible with pyhf v0.6.3
   - Update iminuit API calls

@codecov-commenter
Copy link

Codecov Report

Merging #13 (4c122fb) into master (9b9245d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files           7        7           
  Lines         482      482           
  Branches       82       82           
=======================================
  Hits          456      456           
  Misses         23       23           
  Partials        3        3           
Impacted Files Coverage Δ
src/simplify/fitter.py 100.00% <100.00%> (ø)
src/simplify/model_tools.py 100.00% <100.00%> (ø)
src/simplify/plot.py 100.00% <100.00%> (ø)
src/simplify/yields.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9245d...4c122fb. Read the comment docs.

setup.cfg Outdated Show resolved Hide resolved
@matthewfeickert matthewfeickert changed the title fix: Update with_aux to include_auxdata in pyhf API fix: Update with_aux to include_auxdata in pyhf v0.6.3+ API Nov 8, 2021
@matthewfeickert matthewfeickert added fix API changes public API labels Nov 8, 2021
@matthewfeickert matthewfeickert merged commit d551d26 into eschanet:master Nov 8, 2021
@matthewfeickert
Copy link
Collaborator

@jackaraz @sabinekraml @WolfgangWaltenberger Are you able to try installing simplify from GitHub and give feedback on if this PR resolves all compatibility Issues that you're seeing so far? If so, then we can confirm with @eschanet and then make a new release.

@kratsg kratsg deleted the feat/withAuxAPI branch November 9, 2021 01:20
@WolfgangWaltenberger
Copy link

had to add a file: 
src/simplify/_version.py
version="0.1.9" to make it work (perhaps somehow pip adds this automatically?). 
After this is it seems to work (though I only checked if it works "technically").

Wolfgang

@matthewfeickert
Copy link
Collaborator

matthewfeickert commented Nov 9, 2021

had to add a file:  src/simplify/_version.py version="0.1.9" to make it work (perhaps somehow pip adds this automatically?).

Correct. Like pyhf, simplify uses setuptools_scm to generate the version number

[tool.setuptools_scm]
write_to = "src/simplify/_version.py"

If you pip install from the source locally or from GitHub

python -m pip install --upgrade "git+https://github.com/eschanet/simplify.git#egg=simplify"

pip and setuptools_scm will generate the file.

After this is it seems to work (though I only checked if it works "technically").

Cool, that seems to be good enough to motivate a new release then (after some small cleaning PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API changes public API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants