Skip to content

Commit

Permalink
fix: general fixes
Browse files Browse the repository at this point in the history
FIXED:
* kubernetes_version should be kubernetes-version when tagging the image
with custom metadata.
* set the default cni version to 1.2.0
  • Loading branch information
drew-viles authored Feb 21, 2023
1 parent 8c5d773 commit 1c1e976
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ build:
floating-ip-network-name: "Internet"
image-visibility: "private"
crictl-version: "1.25.0"
cni-version: "1.1.1"
cni-version: "1.2.0"
kubernetes-version: "1.25.3"
extra-debs: "nfs-common"
enable-nvidia-support: true
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/build/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (o *buildOptions) addFlags(cmd *cobra.Command) {
flags.BoolVarWithViper(cmd, &o.userFloatingIP, viperPrefix, "use-floating-ip", true, "Whether to use a floating IP for the instance")
flags.StringVarWithViper(cmd, &o.floatingIPNetworkName, viperPrefix, "floating-ip-network-name", "Internet", "The Name of the network in which to create the floating ip")
flags.StringVarWithViper(cmd, &o.imageVisibility, viperPrefix, "image-visibility", "private", "Change the image visibility in Openstack - you need to ensure the use you're authenticating with has permissions to do so or this will fail")
flags.StringVarWithViper(cmd, &o.cniVersion, viperPrefix, "cni-version", "1.1.1", "The CNI plugins version to include to the built image")
flags.StringVarWithViper(cmd, &o.cniVersion, viperPrefix, "cni-version", "1.2.0", "The CNI plugins version to include to the built image")
flags.StringVarWithViper(cmd, &o.crictlVersion, viperPrefix, "crictl-version", "1.25.0", "The crictl-tools version to add to the built image")
flags.StringVarWithViper(cmd, &o.kubeVersion, viperPrefix, "kubernetes-version", "1.25.3", "The Kubernetes version to add to the built image")
flags.StringVarWithViper(cmd, &o.extraDebs, viperPrefix, "extra-debs", "", "A space-seperated list of any extra (Debian / Ubuntu) packages that should be installed")
Expand Down
2 changes: 1 addition & 1 deletion pkg/openstack/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func GenerateBuilderMetadata() map[string]string {
}
return map[string]string{
"os": viper.GetString("build.build-os"),
"k8s": viper.GetString("build.kubernetes_version"),
"k8s": viper.GetString("build.kubernetes-version"),
"gpu": gpu,
"date": time.RFC3339,
"rootfs_uuid": viper.GetString("build.rootfs-uuid"),
Expand Down

0 comments on commit 1c1e976

Please sign in to comment.