Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falco and trivy #34

Closed
drew-viles opened this issue Apr 11, 2023 · 0 comments
Closed

falco and trivy #34

drew-viles opened this issue Apr 11, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@drew-viles
Copy link
Contributor

drew-viles commented Apr 11, 2023

Pull request #31 was merged but no flags to support the changes in there were added to the cli or viper examples. This needs fixing.

@drew-viles drew-viles added the bug Something isn't working label Apr 11, 2023
@drew-viles drew-viles self-assigned this Apr 11, 2023
drew-viles added a commit that referenced this issue Apr 12, 2023
Previously there were calls to viper.GetSomething all over the code. This was prone to error if a value changed so now the code has been refactored to process any viper inputs.
Flags will always override the viper config file and any fields not supplied will use the defaults where applicable.

Added checksum validation for the Trivy cli download

Removed duplicate Trivy report structs and generally moved some bits around to begin work for allowing other clouds to be used. There is still work to be done to allow other clouds though as it's still generally OpenStack focussed.

Added new docs/readme & changelog

Fixes #32 & Fixes #34

updated README
drew-viles added a commit that referenced this issue Apr 12, 2023
Previously there were calls to viper.GetSomething all over the code. This was prone to error if a value changed so now the code has been refactored to process any viper inputs.
Flags will always override the viper config file and any fields not supplied will use the defaults where applicable.

Added checksum validation for the Trivy cli download

Removed duplicate Trivy report structs and generally moved some bits around to begin work for allowing other clouds to be used. There is still work to be done to allow other clouds though as it's still generally OpenStack focussed.

Added new docs/readme & changelog

Fixes #32 & Fixes #34
drew-viles added a commit that referenced this issue Apr 12, 2023
Previously there were calls to viper.GetSomething all over the code. This was prone to error if a value changed so now the code has been refactored to process any viper inputs.
Flags will always override the viper config file and any fields not supplied will use the defaults where applicable.

Added checksum validation for the Trivy cli download

Removed duplicate Trivy report structs and generally moved some bits around to begin work for allowing other clouds to be used. There is still work to be done to allow other clouds though as it's still generally OpenStack focussed.

Added new docs/readme & changelog

Fixes #32 & Fixes #34
drew-viles added a commit that referenced this issue Apr 12, 2023
Previously there were calls to viper.GetSomething all over the code. This was prone to error if a value changed so now the code has been refactored to process any viper inputs.
Flags will always override the viper config file and any fields not supplied will use the defaults where applicable.

Added checksum validation for the Trivy cli download

Removed duplicate Trivy report structs and generally moved some bits around to begin work for allowing other clouds to be used. There is still work to be done to allow other clouds though as it's still generally OpenStack focussed.

Added new docs/readme & changelog

Fixes #32 & Fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant