Extend Base.setindex #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import Base.setindex, so that this function is extended, instead of creating a new funciton SIMD.setindex. This makes it possible to use SIMD.jl together with e.g. StaticArrays.jl without having to qualify the setindex function on each use. This commit also fixes a bug in the argument order when the index is not an Int.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 1 1
Lines 866 866
=======================================
Hits 745 745
Misses 121 121 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 1 1
Lines 866 866
=======================================
Hits 745 745
Misses 121 121 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports
Base.setindex, so that this function is extended, instead of creating a new funcitonSIMD.setindex.This makes it easier to use SIMD.jl together with StaticArrays.jl (which also exports
Base.setindex).(This PR also fixes a bug in the argument order when the index is not an Int.)
Edit: I just noticed #63, which also fixes the above. Feel free to close this PR if you are planning to merge that one.