Check whether -std=c++11 can be safely added to the compiler flags
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just merged a PR fixing the linting issues |
Thanks! Just merged that in here, so hopefully this should pass then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty minimal fix to #78. I added a
clangbuild to make sure this doesn't regress; this built fails without this fix.Note that you seem to have some linting errors that make the all Python 3.8 and 3.9 build fail, but these are unrelated to this PR I think. I also turned off
fail-fastto make sure that all build jobs run, otherwise they terminate as soon as one fails. For tests, I generally prefer not to usefail-fastto see all possible failures in one go.