Add optional higher order moments #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are part of the sums/sums_cov arrays returned by gmix.get_weighted_moments This is also available with GaussMom(fwhm, higher=True) Currently the sums are calculated and are stored in a larger "sums" and "sums_cov" arrays in the results. No normalized moments are returned. Names and indices for moments can be found in moments.MOMENTS_NAME_MAP
beckermr
requested changes
Nov 1, 2024
|
Here's a question: should we just always calculate these higher order moments? They probably don't cost much compared to evaluating the gaussian, and the user will usually copy what they want out |
|
I am concerned other APIs / users expect the shape on output to be 6x6 so if we always calculated them we'd cause API breaks. |
|
Good point |
gaussmom use default maxrad from gmix
Big enough that the weight function should be zero. chose 100 sigma
didn't matter since its zero...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are part of the sums/sums_cov arrays returned by gmix.get_weighted_moments when
with_higher_order=Trueis sent.This is also available with
GaussMom(fwhm, with_higher_order=True)Currently the sums are calculated and are stored in a larger "sums" and "sums_cov" arrays in the results. No normalized moments are returned.
Names and indices for moments can be found in moments.MOMENTS_NAME_MAP