Skip to content

Commit

Permalink
fix(ui5-textarea): apply specified scrollbar stylings (SAP#4477)
Browse files Browse the repository at this point in the history
  • Loading branch information
niyap authored and eshpak committed Jan 8, 2022
1 parent c6b0db7 commit 6376a2e
Show file tree
Hide file tree
Showing 15 changed files with 29 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/main/src/TextArea.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
// Styles
import styles from "./generated/themes/TextArea.css.js";
import valueStateMessageStyles from "./generated/themes/ValueStateMessage.css.js";
import browserScrollbarCSS from "./generated/themes/BrowserScrollbar.css.js";

/**
* @public
Expand Down Expand Up @@ -360,7 +361,7 @@ class TextArea extends UI5Element {
}

static get styles() {
return styles;
return [browserScrollbarCSS, styles];
}

static get render() {
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/themes/BrowserScrollbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@

::-webkit-scrollbar {
background-color: var(--sapScrollBar_TrackColor);
border-left: var(--browser_scrollbar_border);
}

::-webkit-scrollbar-thumb {
border-radius: var(--browser_scrollbar_border_radius);
background-color: var(--sapScrollBar_FaceColor);
}

Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/themes/base/BrowserScrollbar-parameters.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
:root {
--browser_scrollbar_border_radius: var(--sapElement_BorderCornerRadius);
--browser_scrollbar_border: none;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
:root {
--browser_scrollbar_border_radius: 0;
--browser_scrollbar_border: none;
}
1 change: 1 addition & 0 deletions packages/main/src/themes/sap_belize/parameters-bundle.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "../base/Avatar-parameters.css";
@import "../base/Badge-parameters.css";
@import "./BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "../base/Button-parameters.css";
@import "../base/DatePicker-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
:root {
--browser_scrollbar_border_radius: 0px;
--browser_scrollbar_border: 0.0625rem solid #999;
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "./Badge-parameters.css";
@import "./BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "./CalendarHeader-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
:root {
--browser_scrollbar_border_radius: 0;
--browser_scrollbar_border: 0.0625rem solid #585858;
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "./Badge-parameters.css";
@import "./BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "./CalendarHeader-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/themes/sap_fiori_3/parameters-bundle.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "../base/Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "../base/Card-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "../base/Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "../base/Card-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "./Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "./CalendarHeader-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "./Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "./CalendarHeader-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/themes/sap_horizon/parameters-bundle.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "./sizes-parameters.css";
@import "./Avatar-parameters.css";
@import "../base/Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "./BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "../base/Card-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "../base/sizes-parameters.css";
@import "../base/Avatar-parameters.css";
@import "../base/Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "./Button-parameters.css";
@import "./Badge-parameters.css";
@import "../base/Card-parameters.css";
Expand Down

0 comments on commit 6376a2e

Please sign in to comment.