Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules with mnesia and odbc backends unifications #123

Closed
michalwski opened this issue Nov 19, 2013 · 4 comments
Closed

modules with mnesia and odbc backends unifications #123

michalwski opened this issue Nov 19, 2013 · 4 comments

Comments

@michalwski
Copy link
Contributor

All modules storing data in mnesia or odbc have two version now (named with _odbc suffix or without). The common logic of these modules should be left in the original module and all backend related operations like read/write/update should be moved to some backend modules. Good example of similar solution are session backends (mnesia and redis).

Candidates for such a unification:

  • mod_private(_odbc)
  • mod_vcard(_odbc)
  • mod_roster(_odbc)
  • mod_offline(_odbc)
  • mod_last(_odbc)
  • mod_privacy(_odbc)
@arcusfelis
Copy link
Contributor

mod_private(_odbc) is too small for this.

@michalwski
Copy link
Contributor Author

I know it's small but is that a reason not to unify the logic and keep it duplicated?

@arcusfelis
Copy link
Contributor

michalwski added a commit that referenced this issue Sep 10, 2014
with mnesia and odbc backends
@michalwski
Copy link
Contributor Author

mod_vcard is done in #142
mod_offline is done in #149
mod_last is done in #281

The last piece is mod_roster #139 which is still waiting for rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants