-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cassandra MAM backend performance #1133
Conversation
|
||
%% gen_server callbacks | ||
-export([init/1, handle_call/3, handle_cast/2, handle_info/2, | ||
terminate/2, code_change/3]). | ||
-export([queue_length/1]). | ||
|
||
-behaviour(gen_server). | ||
-behaviour(mongoose_cassandra). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Compiler:
Warning: undefined callback function prepared_queries/0 (behaviour 'mongoose_cassandra')
a028759
to
f6da1e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to split this PR into 2?
- With only
seestar
tocql
change. - Performance improvements.
@@ -1,4 +1,5 @@ | |||
language: erlang | |||
dist: trusty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presets from "matrix" by default run on 12.04 which is unable to compile one of the new dependencies due to lack of C++11 support in GCC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Sounds like a bug in travis though.
c60e291
to
c6e6bd1
Compare
For just the Cassandra client change, please see #1145 . |
8081196
to
c834285
Compare
Thanks! |
This PR changes cassandra's client library to cqerl which is better supported by community then seestar. Also there are some changes in cassandra DB schema in order to improve query performance.