Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cassandra MAM backend performance #1133

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

rslota
Copy link
Contributor

@rslota rslota commented Dec 23, 2016

This PR changes cassandra's client library to cqerl which is better supported by community then seestar. Also there are some changes in cassandra DB schema in order to improve query performance.


%% gen_server callbacks
-export([init/1, handle_call/3, handle_cast/2, handle_info/2,
terminate/2, code_change/3]).
-export([queue_length/1]).

-behaviour(gen_server).
-behaviour(mongoose_cassandra).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Compiler:

Warning: undefined callback function prepared_queries/0 (behaviour 'mongoose_cassandra')

@rslota rslota force-pushed the feature/improve-cassandra-performance branch 2 times, most recently from a028759 to f6da1e2 Compare December 23, 2016 16:54
Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to split this PR into 2?

  1. With only seestar to cql change.
  2. Performance improvements.

@@ -1,4 +1,5 @@
language: erlang
dist: trusty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presets from "matrix" by default run on 12.04 which is unable to compile one of the new dependencies due to lack of C++11 support in GCC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Sounds like a bug in travis though.

@rslota rslota force-pushed the feature/improve-cassandra-performance branch from c60e291 to c6e6bd1 Compare January 10, 2017 14:56
@rslota
Copy link
Contributor Author

rslota commented Jan 12, 2017

For just the Cassandra client change, please see #1145 .

@rslota rslota force-pushed the feature/improve-cassandra-performance branch 7 times, most recently from 8081196 to c834285 Compare January 19, 2017 11:15
@michalwski michalwski merged commit 25837ba into master Jan 19, 2017
@michalwski michalwski deleted the feature/improve-cassandra-performance branch January 19, 2017 15:40
@michalwski
Copy link
Contributor

Thanks!

This was referenced Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants