Add support for XEP-0363 (HTTP Upload) version 0.3.0. #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzemek
force-pushed
the
http_upload_0_3
branch
from
e2c4318 to
3547fa2
Compare
michalwski
reviewed
Feb 16, 2017
|
|
||
| case is_binary(Filename) andalso <<>> =/= Filename | ||
| andalso is_integer(Size) andalso Size >= 0 of | ||
| case is_binary(Filename) andalso <<>> =/= Filename andalso is_integer(Size) andalso Size >= 0 of |
There was a problem hiding this comment.
This conditional consists of 4 parts. I think it would more readable and easier to understand if
is_binary(Filename) andalso <<>> =/= Filename andalso is_integer(Size) andalso Size >= 0where encapsulated in a function with some meaningful name, f.e is_filename_and_size_acceptable.
kzemek
force-pushed
the
http_upload_0_3
branch
from
c6e6c1e to
542ffb5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for XEP-0363 v 0.3.0 while preserving backwards compatibility with version 0.2.5 (which looks to have conforming client implementations).