-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dots in "host" part of metric name with underscores. #2025
base: master
Are you sure you want to change the base?
Conversation
Underscores are not a valid part of a domain name, so they are safe to replace dots to in the metric name (i.e. this can't lead to a collision with an existing host name). Replacing dots with underscores prevents hosts from being treated as multiple separate metrics nodes e.g. by Graphite and Grafana.
5360.1 / Erlang 19.3 / small_tests / c09f1a8 5360.3 / Erlang 19.3 / mysql_redis / c09f1a8 5360.2 / Erlang 19.3 / internal_mnesia / c09f1a8 5360.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / c09f1a8 5360.5 / Erlang 19.3 / ldap_mnesia / c09f1a8 5360.4 / Erlang 19.3 / odbc_mssql_mnesia / c09f1a8 5360.8 / Erlang 20.0 / pgsql_mnesia / c09f1a8 5360.9 / Erlang 21.0 / riak_mnesia / c09f1a8 |
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
+ Coverage 74.92% 75.02% +0.09%
==========================================
Files 314 314
Lines 28619 28621 +2
==========================================
+ Hits 21444 21472 +28
+ Misses 7175 7149 -26
Continue to review full report at Codecov.
|
5361.1 / Erlang 19.3 / small_tests / da2b9dd 5361.3 / Erlang 19.3 / mysql_redis / da2b9dd 5361.2 / Erlang 19.3 / internal_mnesia / da2b9dd 5361.4 / Erlang 19.3 / odbc_mssql_mnesia / da2b9dd 5361.5 / Erlang 19.3 / ldap_mnesia / da2b9dd 5361.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / da2b9dd 5361.8 / Erlang 20.0 / pgsql_mnesia / da2b9dd 5361.9 / Erlang 21.0 / riak_mnesia / da2b9dd 5361.9 / Erlang 21.0 / riak_mnesia / da2b9dd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It should be configurable for now with a clear deprecation warning (for domains with dots) as it breaks compatibility with existing deployments.
Mongoose-metrics.md
update is necessary. Possibly there are more sections in documentation that should be changes as well.
Underscores are not a valid part of a domain name, so they
are safe to replace dots to in the metric name (i.e. this can't lead
to a collision with an existing host name).
Replacing dots with underscores prevents hosts from being treated
as multiple separate metrics nodes e.g. by Graphite and Grafana.