Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dsaparam argument when generating DH parameters to speed up generation #2305

Merged
merged 1 commit into from
May 22, 2019

Conversation

arcusfelis
Copy link
Contributor

Speed up tests on travis a little bit.

Comparing "cd tools/ssl && time make"

Before:
make 10.26s user 0.13s system 99% cpu 10.487 total

After:
make 5.46s user 0.10s system 98% cpu 5.625 total

@mongoose-im
Copy link
Collaborator

mongoose-im commented May 16, 2019

6502.1 / Erlang 19.3 / small_tests / 87454a4
Reports root / small


6502.3 / Erlang 19.3 / mysql_redis / 87454a4
Reports root/ big
OK: 3097 / Failed: 0 / User-skipped: 232 / Auto-skipped: 0


6502.2 / Erlang 19.3 / internal_mnesia / 87454a4
Reports root/ big
OK: 1250 / Failed: 2 / User-skipped: 68 / Auto-skipped: 0

pubsub_SUITE:tree+basic:discover_nodes_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,468}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,458}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,448}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1045}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,977}]}]}}

Report log

mod_global_distrib_SUITE:mod_global_distrib:test_pm_with_ungraceful_reconnection_to_different_server
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"eve39.231890@localhost/res1">>,escalus_tcp,
          <0.18476.1>,
          [{event_manager,<0.18467.1>},
           {server,<<"localhost">>},
           {username,<<"eve39.231890">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18467.1>},
            {server,<<"localhost">>},
            {username,<<"eve39.231890">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"eve39.231890">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"eve39.231890">>},
           {server,<<"localhost">>},
           {password,<<"password">>},
           {port,5222},
           {stream_management,true},
           {stream_id,<<"A67103A95FBF599F">>}]},
        10000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {mod_global_distrib_SUITE,
       '-test_pm_with_ungraceful_reconnection_to_different_server/1-fun-0-',
       4,
       [{file,"mod_global_distrib_SUITE.erl"},{line,610}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
    ...

Report log


6502.4 / Erlang 19.3 / odbc_mssql_mnesia / 87454a4
Reports root/ big
OK: 3099 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


6502.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 87454a4
Reports root/ big
OK: 469 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0


6502.5 / Erlang 19.3 / ldap_mnesia / 87454a4
Reports root/ big
OK: 1185 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


6502.8 / Erlang 20.0 / pgsql_mnesia / 87454a4
Reports root/ big / small
OK: 3138 / Failed: 1 / User-skipped: 198 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s
{error,{{assertion_failed,assert_many,true,
              [is_presence,#Fun<sm_SUITE.16.57904926>],
              [{xmlel,<<"presence">>,
                  [{<<"from">>,
                  <<"alicE25.472261@localhost/escalus-default-resource">>},
                   {<<"to">>,
                  <<"alice25.472261@localhost/escalus-default-resource">>},
                   {<<"xml:lang">>,<<"en">>}],
                  []},
               {xmlel,<<"presence">>,
                  [{<<"from">>,
                  <<"alicE25.472261@localhost/escalus-default-resource">>},
                   {<<"to">>,
                  <<"alice25.472261@localhost/escalus-default-resource">>},
                   {<<"xml:lang">>,<<"en">>}],
                  []}],
              "   <presence from='alicE25.472261@localhost/escalus-default-resource' to='alice25.472261@localhost/escalus-default-resource' xml:lang='en'/>   <presence from='alicE25.472261@localhost/escalus-default-resource' to='alice25.472261@localhost/escalus-default-resource' xml:lang='en'/>"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {sm_SUITE,resume_session_state_stop_c2s,1,
           [{file,"sm_SUITE.erl"},{line,581}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1045}]},
     {...

Report log


6502.9 / Erlang 21.0 / riak_mnesia / 87454a4
Reports root/ big / small
OK: 1472 / Failed: 1 / User-skipped: 66 / Auto-skipped: 0

pubsub_SUITE:dag+basic:subscribe_options_test
{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,[]},
           <<"pubsub#deliver">>}},
    [{pubsub_tools,'-verify_form_values/2-fun-0-',2,
             [{file,"pubsub_tools.erl"},{line,627}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1338}]},
     {pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
             [{file,"pubsub_SUITE.erl"},{line,422}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1545}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1063}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,995}]}]}}

Report log


6502.9 / Erlang 21.0 / riak_mnesia / 87454a4
Reports root/ big / small
OK: 1472 / Failed: 1 / User-skipped: 66 / Auto-skipped: 0

pubsub_SUITE:dag+basic:discover_nodes_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,468}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,458}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,448}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1545}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1063}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,995}]}]}}

Report log

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #2305 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
+ Coverage   78.68%   79.05%   +0.36%     
==========================================
  Files         334      334              
  Lines       29026    29026              
==========================================
+ Hits        22839    22946     +107     
+ Misses       6187     6080     -107
Impacted Files Coverage Δ
src/mongoose_tcp_listener.erl 73.68% <0%> (-5.27%) ⬇️
src/mod_roster.erl 79.86% <0%> (-0.24%) ⬇️
src/mod_muc_log.erl 77.69% <0%> (ø) ⬆️
src/ejabberd_c2s.erl 87.18% <0%> (+0.07%) ⬆️
src/pubsub/mod_pubsub.erl 72.19% <0%> (+0.3%) ⬆️
src/mod_muc_room.erl 77.03% <0%> (+0.41%) ⬆️
src/pubsub/node_flat.erl 73.83% <0%> (+0.42%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 95.15% <0%> (+0.44%) ⬆️
src/mam/mod_mam.erl 90.36% <0%> (+0.45%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 83.09% <0%> (+0.7%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf1c1c...295ed72. Read the comment docs.

@fenek fenek merged commit b02d165 into master May 22, 2019
@fenek fenek deleted the use-ssl-dsaparam-for-fake-certs branch May 22, 2019 10:53
@fenek fenek added this to the MongooseIM 3.3.0++ milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants