Remove personal data from mod_inbox #2309

zofpolkowska · 2019-05-17T08:11:24Z

This PR addresses MIM-336

ludwikbukowski · 2019-05-17T08:15:13Z

big_tests/tests/gdpr_SUITE.erl

+            ExpectedHeader = ["jid", "content", "unread_count", "timestamp"],
+            maybe_stop_and_unload_module(mod_inbox, mod_inbox_backend, Config),
+            {0, _} = unregister(Alice, Config),
+            {0, _} = unregister(Bob, Config),


Actually, more interesting would be the test, in which we do not register the second user, and we validate that he still has an inbox after removal of the first one. When we unregister two users and check they have empty inboxes, its like we test exactly the same scenario but twice

You mean do not unregister ?

Yes, sorry, this is what I meant.
Just unregister Alice and do not touch Bob

ludwikbukowski · 2019-05-17T08:23:04Z

Could we add one test for inbox removal for muclight room?

mongoose-im · 2019-05-17T08:42:00Z

6511.1 / Erlang 19.3 / small_tests / 457504c
Reports root / small

6511.2 / Erlang 19.3 / internal_mnesia / 457504c
Reports root/ big
OK: 1246 / Failed: 1 / User-skipped: 70 / Auto-skipped: 0

sm_SUITE:parallel:subscription_requests_are_buffered_properly

{error,{{badmatch,false},
    [{escalus_session,stream_management,2,
              [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,227}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,134}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_connection,start,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,118}]},
     {sm_SUITE,'-subscription_requests_are_buffered_properly/1-fun-3-',6,
           [{file,"sm_SUITE.erl"},{line,848}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1045}]}]}}


		-define(ROOM, <<"tt1">>).

		-define(MUCHOST, <<"muclight.@HOST@">>).

+                  [{aff_changes, true},
+                   {remove_on_kicked, true},
+                   {groupchat, [muc]},
+                   {markers, [displayed]}].

		{markers, [displayed]}].


		prepare_room(Owner, Members, Config) ->

+                      ExpectedAliceItems = [
+                                            #{
+                        "jid" => [{contains, <<"muclight.localhost">>},
+                                  {contains, ?ROOM}],

+                      retrieve_and_validate_personal_data(
+                        Bob, Config, "inbox", ExpectedHeader, ExpectedBobItems),
+                      StanzaDestroy = escalus_stanza:to(escalus_stanza:iq_set(?NS_MUC_LIGHT_DESTROY, []),

+                      RoomAddr = muc_helper:room_address(Room),
+                      inbox_helper:enter_room(Room, Users),
+                      inbox_helper:make_members(Room, Alice, Users -- [Alice]),

+                                               "unread_count" => "1" }
+                                           ],
+                      ExpectedBobItems = [#{
+                        "jid" => [{contains, Room},

+                      end).
+              remove_inbox_muc(Config) ->
+                  escalus:story(Config, [{alice, 1}, {bob, 1}], fun(Alice, Bob) ->

+              init_per_testcase(CN, Config) when CN =:= retrieve_inbox_muc;
+                                                 CN =:= remove_inbox_muc ->
+                  muc_helper:load_muc(muc_domain()),
+                  Config1 = escalus:create_users(Config, escalus:get_users([alice, bob])),

+                  Users = ?config(escalus_users, Config1),
+                  Alice = lists:keyfind(alice, 1, Users),
+                  RoomName = muc_helper:fresh_room_name(),
+                  Config2 = muc_helper:start_room(Config1, Alice, RoomName, <<"some_friendly_name">>, default),

Remove personal data from mod_inbox #2309

Remove personal data from mod_inbox #2309

Conversation

zofpolkowska commented May 17, 2019

ludwikbukowski May 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ludwikbukowski May 17, 2019 • edited Loading

Choose a reason for hiding this comment

ludwikbukowski commented May 17, 2019 • edited Loading

mongoose-im commented May 17, 2019 • edited Loading

codecov bot commented May 17, 2019 • edited Loading

Codecov Report

mongoose-im commented May 20, 2019 • edited Loading

Choose a reason for hiding this comment

ludwikbukowski May 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ludwikbukowski May 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ludwikbukowski May 23, 2019 • edited Loading

Choose a reason for hiding this comment

mongoose-im commented May 23, 2019 • edited Loading

mongoose-im commented May 23, 2019 • edited Loading

mongoose-im commented May 28, 2019 • edited Loading

mongoose-im commented May 29, 2019 • edited Loading

ludwikbukowski May 17, 2019 •

edited

Loading

ludwikbukowski May 17, 2019 •

edited

Loading

ludwikbukowski commented May 17, 2019 •

edited

Loading

mongoose-im commented May 17, 2019 •

edited

Loading

codecov bot commented May 17, 2019 •

edited

Loading

mongoose-im commented May 20, 2019 •

edited

Loading

ludwikbukowski May 23, 2019 •

edited

Loading

ludwikbukowski May 23, 2019 •

edited

Loading

ludwikbukowski May 23, 2019 •

edited

Loading

mongoose-im commented May 23, 2019 •

edited

Loading

mongoose-im commented May 23, 2019 •

edited

Loading

mongoose-im commented May 28, 2019 •

edited

Loading

mongoose-im commented May 29, 2019 •

edited

Loading