Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu20 #2949

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Ubuntu20 #2949

merged 3 commits into from
Nov 24, 2020

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Nov 20, 2020

Ubuntu machines in CircleCI are updated to use 20.04, python2 and pip2 are not used anymore, and the docker image is built with phusion/focal-1.0.0-alpha1-amd64 (needs esl/mongooseim-docker#40 be merged first).

@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2949 (e8a5266) into master (5f8b232) will decrease coverage by 0.11%.
The diff coverage is 76.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
- Coverage   79.19%   79.08%   -0.12%     
==========================================
  Files         377      377              
  Lines       32795    32846      +51     
==========================================
+ Hits        25973    25975       +2     
- Misses       6822     6871      +49     
Impacted Files Coverage Δ
src/rdbms/rdbms_queries_mssql.erl 100.00% <ø> (+14.28%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 93.83% <62.50%> (-0.86%) ⬇️
src/mod_vcard_rdbms.erl 74.49% <74.63%> (-6.46%) ⬇️
src/rdbms/mongoose_rdbms_odbc.erl 77.64% <81.81%> (-3.08%) ⬇️
src/mam/mod_mam_muc_rdbms_arch.erl 88.51% <100.00%> (ø)
src/mam/mod_mam_rdbms_arch.erl 39.27% <100.00%> (ø)
src/mod_vcard.erl 75.91% <100.00%> (ø)
src/mod_vcard_mnesia.erl 80.45% <100.00%> (+0.45%) ⬆️
src/rdbms/mongoose_rdbms.erl 65.40% <100.00%> (-0.32%) ⬇️
src/rdbms/rdbms_queries.erl 82.55% <100.00%> (-1.47%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be82de...d6c7e14. Read the comment docs.

@NelsonVides
Copy link
Collaborator Author

NelsonVides commented Nov 20, 2020

Seems like dropping the s3-parallel-put plugin increments times to upload results from ~40s to ~2min40s 😕
With and Without the plugin.
BUT, after raising awscli concurrency like in 54aa0bd, now uploading results are much closer to the old value, at around ~1min, like here

@mongoose-im

This comment has been minimized.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 22, 2020

8745.1 / Erlang 23.0.3 / small_tests / b157d00
Reports root / small


8745.2 / Erlang 23.0.3 / internal_mnesia / b157d00
Reports root/ big
OK: 1494 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0


8745.3 / Erlang 23.0.3 / odbc_mssql_mnesia / b157d00
Reports root/ big
OK: 2770 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


8745.4 / Erlang 23.0.3 / mysql_redis / b157d00
Reports root/ big
OK: 2765 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0


8745.6 / Erlang 23.0.3 / ldap_mnesia / b157d00
Reports root/ big
OK: 1404 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0


8745.5 / Erlang 23.0.3 / riak_mnesia / b157d00
Reports root/ big
OK: 1628 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0


8745.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / b157d00
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


8745.9 / Erlang 22.3 / pgsql_mnesia / b157d00
Reports root/ big / small
OK: 2783 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@NelsonVides NelsonVides force-pushed the ubuntu20 branch 6 times, most recently from 5be5abc to 121045a Compare November 23, 2020 15:30
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, especially getting rid of Python 2.
Could you add the description to this PR?
Also, what is the plan with Travis?

@NelsonVides
Copy link
Collaborator Author

The changes look good, especially getting rid of Python 2.
Could you add the description to this PR?
Also, what is the plan with Travis?

Updated the description, but we need to first merge the PR for the mim-docker repo. About Travis, don't really know, I could try updating it to use focal as well, but it's taking really ages to run so it'd take forever to iterate on it, and we might drop it... Maybe it could be a separate task to update travis as well

@chrzaszcz
Copy link
Member

chrzaszcz commented Nov 24, 2020

Maybe it could be a separate task to update travis as well

I only meant running the tests on travis, I see they were canceled. I am also thinking we might drop Travis soon with its recent changes, but for now maybe we should just build it on Travis without changing the settings there.

@chrzaszcz
Copy link
Member

Updated the description, but we need to first merge the PR for the mim-docker repo.

Done

s3-parallel-put is not needed, can be swapped by awscli and a higher
maximum for concurrency requests. Python is only needed for codecov, and
can use the already installed pip3.
@NelsonVides NelsonVides force-pushed the ubuntu20 branch 2 times, most recently from ab52478 to 2bd8c36 Compare November 24, 2020 09:20
@NelsonVides NelsonVides marked this pull request as ready for review November 24, 2020 09:21
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The docker image runs correctly, shows the right OS version and MongooseIM accepts connections.

We agreed that from now on the Travis builds are not necessary, so I am merging this one.

@chrzaszcz chrzaszcz merged commit 39fafdf into master Nov 24, 2020
@chrzaszcz chrzaszcz deleted the ubuntu20 branch November 24, 2020 13:38
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants