-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu20 #2949
Conversation
d3f3f00
to
b55ec75
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
==========================================
- Coverage 79.19% 79.08% -0.12%
==========================================
Files 377 377
Lines 32795 32846 +51
==========================================
+ Hits 25973 25975 +2
- Misses 6822 6871 +49
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
8745.1 / Erlang 23.0.3 / small_tests / b157d00 8745.2 / Erlang 23.0.3 / internal_mnesia / b157d00 8745.3 / Erlang 23.0.3 / odbc_mssql_mnesia / b157d00 8745.4 / Erlang 23.0.3 / mysql_redis / b157d00 8745.6 / Erlang 23.0.3 / ldap_mnesia / b157d00 8745.5 / Erlang 23.0.3 / riak_mnesia / b157d00 8745.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / b157d00 8745.9 / Erlang 22.3 / pgsql_mnesia / b157d00 |
5be5abc
to
121045a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, especially getting rid of Python 2.
Could you add the description to this PR?
Also, what is the plan with Travis?
Updated the description, but we need to first merge the PR for the mim-docker repo. About Travis, don't really know, I could try updating it to use focal as well, but it's taking really ages to run so it'd take forever to iterate on it, and we might drop it... Maybe it could be a separate task to update travis as well |
I only meant running the tests on travis, I see they were canceled. I am also thinking we might drop Travis soon with its recent changes, but for now maybe we should just build it on Travis without changing the settings there. |
Done |
121045a
to
d7fcb4d
Compare
s3-parallel-put is not needed, can be swapped by awscli and a higher maximum for concurrency requests. Python is only needed for codecov, and can use the already installed pip3.
ab52478
to
2bd8c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. The docker image runs correctly, shows the right OS version and MongooseIM accepts connections.
We agreed that from now on the Travis builds are not necessary, so I am merging this one.
Ubuntu machines in CircleCI are updated to use 20.04, python2 and pip2 are not used anymore, and the docker image is built with
phusion/focal-1.0.0-alpha1-amd64
(needs esl/mongooseim-docker#40 be merged first).