Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect minio in CI #2998

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Correctly detect minio in CI #2998

merged 1 commit into from
Jan 7, 2021

Conversation

NelsonVides
Copy link
Collaborator

Big tests are checking if minio should be running, that is, if the preset in the ct specs says it should, and not if it is actually running. And the way this was checked wasn't correct, the keyword to check for was changed and also some nesting was added, during the toml epic.

We can see that minio wasn't being tested here: https://circleci-mim-results.s3.eu-central-1.amazonaws.com/branch/master/42088/internal_mnesia.23.0.3-1/big/ct_run.test@default-85d626ba-85ec-463e-892e-37d6f216922c.2021-01-05_15.00.49/big_tests.tests.mod_http_upload_SUITE.logs/run.2021-01-05_15.08.13/suite.log.html

Exported as a helper function to a separate file, to reduce duplication.
Also, introduce awareness of the new key in the nesting, `toml`, a
change that was forgotten early on.
@DenysGonchar DenysGonchar self-requested a review January 7, 2021 11:55
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, the check indeed was broken with the toml config rework.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 7, 2021

8983.1 / Erlang 23.0.3 / small_tests / 0c302e9
Reports root / small


8983.2 / Erlang 23.0.3 / internal_mnesia / 0c302e9
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 160 / Auto-skipped: 0


8983.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 0c302e9
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


8983.4 / Erlang 23.0.3 / mysql_redis / 0c302e9
Reports root/ big
OK: 2768 / Failed: 1 / User-skipped: 233 / Auto-skipped: 0

pubsub_SUITE:dag+collection_config:disable_notifications_leaf_test
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log


8983.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 0c302e9
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


8983.6 / Erlang 23.0.3 / ldap_mnesia / 0c302e9
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0


8983.5 / Erlang 23.0.3 / riak_mnesia / 0c302e9
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0


8983.9 / Erlang 22.3 / pgsql_mnesia / 0c302e9
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #2998 (821eef2) into master (d5c1586) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
- Coverage   79.12%   79.10%   -0.03%     
==========================================
  Files         377      377              
  Lines       32840    32840              
==========================================
- Hits        25986    25978       -8     
- Misses       6854     6862       +8     
Impacted Files Coverage Δ
src/mam/mod_mam_rdbms_prefs.erl 90.99% <0.00%> (-3.61%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.40% <0.00%> (-1.90%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/ejabberd_local.erl 71.64% <0.00%> (-1.50%) ⬇️
src/muc_light/mod_muc_light.erl 82.19% <0.00%> (-0.92%) ⬇️
src/mam/mod_mam_utils.erl 88.99% <0.00%> (-0.65%) ⬇️
src/pubsub/mod_pubsub.erl 71.87% <0.00%> (-0.30%) ⬇️
src/mod_muc_room.erl 77.42% <0.00%> (-0.12%) ⬇️
src/ejabberd_c2s.erl 89.26% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 77.29% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c1586...821eef2. Read the comment docs.

@chrzaszcz chrzaszcz merged commit 123f62e into master Jan 7, 2021
@chrzaszcz chrzaszcz deleted the minio_testing_recover branch January 7, 2021 16:07
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants