-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly detect minio in CI #2998
Conversation
Exported as a helper function to a separate file, to reduce duplication. Also, introduce awareness of the new key in the nesting, `toml`, a change that was forgotten early on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, the check indeed was broken with the toml config rework.
8983.1 / Erlang 23.0.3 / small_tests / 0c302e9 8983.2 / Erlang 23.0.3 / internal_mnesia / 0c302e9 8983.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 0c302e9 8983.4 / Erlang 23.0.3 / mysql_redis / 0c302e9 pubsub_SUITE:dag+collection_config:disable_notifications_leaf_test{'EXIT',
{fw_error,
{ct_framework,error_notification,
{{case_clause,[]},
[{ct_framework,error_notification,4,
[{file,"ct_framework.erl"},{line,997}]},
{test_server_sup,framework_call,4,
[{file,"test_server_sup.erl"},{line,778}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1268}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}}}} 8983.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 0c302e9 8983.6 / Erlang 23.0.3 / ldap_mnesia / 0c302e9 8983.5 / Erlang 23.0.3 / riak_mnesia / 0c302e9 8983.9 / Erlang 22.3 / pgsql_mnesia / 0c302e9 |
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 79.12% 79.10% -0.03%
==========================================
Files 377 377
Lines 32840 32840
==========================================
- Hits 25986 25978 -8
- Misses 6854 6862 +8
Continue to review full report at Codecov.
|
Big tests are checking if minio should be running, that is, if the preset in the ct specs says it should, and not if it is actually running. And the way this was checked wasn't correct, the keyword to check for was changed and also some nesting was added, during the toml epic.
We can see that minio wasn't being tested here: https://circleci-mim-results.s3.eu-central-1.amazonaws.com/branch/master/42088/internal_mnesia.23.0.3-1/big/ct_run.test@default-85d626ba-85ec-463e-892e-37d6f216922c.2021-01-05_15.00.49/big_tests.tests.mod_http_upload_SUITE.logs/run.2021-01-05_15.08.13/suite.log.html