Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep publish options #3017

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Pep publish options #3017

merged 3 commits into from
Feb 1, 2021

Conversation

janciesla8818
Copy link
Contributor

This PR addresses handling of publish-options, which allows specifying options along with a publish request.

This PR should be merged after escalus PR is merged.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 28, 2021

9046.1 / Erlang 23.0.3 / small_tests / b5cf9b5
Reports root / small


9046.2 / Erlang 23.0.3 / internal_mnesia / b5cf9b5
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9046.3 / Erlang 23.0.3 / odbc_mssql_mnesia / b5cf9b5
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9046.4 / Erlang 23.0.3 / mysql_redis / b5cf9b5
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9046.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / b5cf9b5
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9046.5 / Erlang 23.0.3 / riak_mnesia / b5cf9b5
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9046.6 / Erlang 23.0.3 / ldap_mnesia / b5cf9b5
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9046.9 / Erlang 22.3 / pgsql_mnesia / b5cf9b5
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #3017 (f34a0af) into master (e727689) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
- Coverage   78.55%   78.53%   -0.02%     
==========================================
  Files         376      376              
  Lines       31488    31488              
==========================================
- Hits        24734    24730       -4     
- Misses       6754     6758       +4     
Impacted Files Coverage Δ
src/pubsub/node_pep.erl 76.47% <ø> (ø)
src/pubsub/mod_pubsub.erl 72.00% <100.00%> (+0.05%) ⬆️
src/ejabberd_s2s_out.erl 57.89% <0.00%> (-2.29%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 73.11% <0.00%> (-0.48%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/mod_muc_room.erl 77.60% <0.00%> (+0.05%) ⬆️
src/mod_roster.erl 77.95% <0.00%> (+0.46%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e727689...f34a0af. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 29, 2021

9047.1 / Erlang 23.0.3 / small_tests / b4a2da4
Reports root / small


9047.2 / Erlang 23.0.3 / internal_mnesia / b4a2da4
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9047.3 / Erlang 23.0.3 / odbc_mssql_mnesia / b4a2da4
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9047.4 / Erlang 23.0.3 / mysql_redis / b4a2da4
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9047.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / b4a2da4
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9047.5 / Erlang 23.0.3 / riak_mnesia / b4a2da4
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9047.6 / Erlang 23.0.3 / ldap_mnesia / b4a2da4
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9047.9 / Erlang 22.3 / pgsql_mnesia / b4a2da4
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arcusfelis arcusfelis merged commit 6d48b61 into master Feb 1, 2021
@arcusfelis arcusfelis deleted the pep-publish-options branch February 1, 2021 11:56
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants