REST and CLI API for domains

[arcusfelis]

This PR addresses "REST and CLI API for domains".

Proposed changes include:

• insert_domain
• enable/disable
• select_domain over REST.

[codecov]

Codecov Report

Merging #3058 (e7bef6d) into multi-tenancy-phase-1 (f991ee2) will increase coverage by 0.60%.
The diff coverage is 90.41%.

@@                    Coverage Diff                    @@
##           multi-tenancy-phase-1    #3058      +/-   ##
=========================================================
+ Coverage                  78.09%   78.70%   +0.60%     
=========================================================
  Files                        374      387      +13     
  Lines                      31219    31576     +357     
=========================================================
+ Hits                       24382    24851     +469     
+ Misses                      6837     6725     -112     

Impacted Files	Coverage Δ
src/admin_extra/service_admin_extra.erl	100.00% <ø> (ø)
src/auth/ejabberd_auth_anonymous.erl	48.75% <0.00%> (-1.25%)	⬇️
src/domain/mongoose_domain_utils.erl	0.00% <0.00%> (ø)
src/ejabberd_gen_sm.erl	90.90% <ø> (ø)
src/ejabberd_local.erl	62.68% <0.00%> (-1.50%)	⬇️
src/muc_light/mod_muc_light_db_mnesia.erl	89.47% <ø> (+4.47%)	⬆️
src/offline/mod_offline_mnesia.erl	51.47% <0.00%> (ø)
src/pubsub/pubsub_form_utils.erl	56.60% <0.00%> (+1.04%)	⬆️
src/rdbms/rdbms_queries_mssql.erl	100.00% <ø> (ø)
src/rdbms/mongoose_rdbms_odbc.erl	75.78% <45.45%> (-1.86%)	⬇️
... and 96 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3626394...e7bef6d. Read the comment docs.

[NelsonVides]

I'm afraid that mongoose_domain_h and service_admin_extra_domain are insanely similar to each other, I'm sad about the repeated code 😿 But I don't care about that, I'm mostly concerned, why basically not a single error-path has test coverage? Are we only testing happy cases? Can that be improved?

[NelsonVides]

Test coverage is much better now, but codecov shows some missing coverage for deleting domains errors, can we throw a bunch of tests there as well?

[chrzaszcz]

Looks good. I added a few minor remarks. There are two more observations:

• Adding tests for unhappy paths in the REST API would be good. This can be done later.
• Newly added modules are missing specs, adding them in subsequent PR's would be nice as well.

[chrzaszcz]

Good work! A lot of tests! Only one comment from me.

[NelsonVides]

All fine. Tests could have been organised to run in parallel when possible and then cut suite time, but anyway, we can leave that for the future.