Remove untested and outdated 'azuresql.sql' #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3086 +/- ##
==========================================
- Coverage 78.84% 78.82% -0.02%
==========================================
Files 377 377
Lines 31259 31259
==========================================
- Hits 24645 24641 -4
- Misses 6614 6618 +4
Continue to review full report at Codecov.
|
leszke
approved these changes
Apr 16, 2021
| @@ -200,11 +200,11 @@ ALTER DATABASE $name_of_your_db SET READ_COMMITTED_SNAPSHOT ON | |||
|
|
|||
| The command above may take some time. | |||
|
|
|||
| Then you need to import the SQL schema from either ``mssql2012.sql`` or ``azuresql.sql`` file depending on which database you are using. | |||
| Then you need to import the SQL schema from ``mssql2012.sql``. | |||
There was a problem hiding this comment.
Minor: I think that single grave accents are enough:
Suggested change
| Then you need to import the SQL schema from ``mssql2012.sql``. | |
| Then you need to import the SQL schema from `mssql2012.sql`. |
leszke
added a commit
that referenced
this pull request
Apr 19, 2021
leszke
added a commit
that referenced
this pull request
Apr 19, 2021
leszke
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was outdated, unsupported and untested.
The docs were misleading, because they gave an impression that it was up to date and working.
We can bring it back when a need arises and there is a way to test it.