Handle remove_domain in mod_muc_light #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3107 +/- ##
==========================================
+ Coverage 79.15% 79.20% +0.04%
==========================================
Files 387 387
Lines 31832 31853 +21
==========================================
+ Hits 25196 25228 +32
+ Misses 6636 6625 -11
Continue to review full report at Codecov.
|
chrzaszcz
approved these changes
May 4, 2021
| @@ -131,6 +132,10 @@ remove_user(UserUS, Version) -> | |||
| {atomic, Res} = mnesia:transaction(fun remove_user_transaction/2, [UserUS, Version]), | |||
| Res. | |||
|
|
|||
| -spec remove_domain(mongooseim:host_type(), jid:lserver(), jid:lserver()) -> ok. | |||
| remove_domain(_HostType, _RoomS, _LServer) -> | |||
| ok. | |||
There was a problem hiding this comment.
Just a note: we might mark Mnesia support as TODO somewhere not to forget about it
There was a problem hiding this comment.
I will not forget :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses "Domain removal"
Proposed changes include:
TODO: