-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitenancy/inbox #3132
Multitenancy/inbox #3132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3132 +/- ##
==========================================
+ Coverage 79.45% 79.46% +0.01%
==========================================
Files 395 395
Lines 32170 32175 +5
==========================================
+ Hits 25560 25568 +8
+ Misses 6610 6607 -3
Continue to review full report at Codecov.
|
dcfdc2c
to
c226c8b
Compare
c226c8b
to
f221a0d
Compare
big_tests/tests/dynamic_modules.erl
Outdated
start_running(Config) -> | ||
Domain = ct:get_config({hosts, mim, domain}), | ||
HostType = domain_helper:host_type(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't stop_running/2
also be changed to use HostType?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, good one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good, my main concern is that all the execute_*
functions are not converted to host types yet.
@chrzaszcz Changes applied. When it comes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided with @NelsonVides that adapting the backends to work with host types will be done in a follow-up PR.
This PR attempts to prepare inbox to be multitenancy ready.
NOTE, important TODOs for the near future: