-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitenancy/inbox #3141
Multitenancy/inbox #3141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3141 +/- ##
==========================================
+ Coverage 79.49% 79.51% +0.01%
==========================================
Files 397 397
Lines 32324 32320 -4
==========================================
+ Hits 25695 25698 +3
+ Misses 6629 6622 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes! I have a few comments.
c234132
to
1f63c7b
Compare
This PR most importantly enables (and fixes) muc/muclight tests for inbox and dynamic domains.
It also migrates inbox's backend to HostTypes in an orderly manner, following the pattern of the auth modules. As a side-note, some functions started taking too many parameters, so I made a type
{LUser, LServer, RemBareJid}
, which replicates the primary key that identifies inbox entries.