-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating mod_stream_management module #3149
Conversation
87acc6a
to
2aa31b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
==========================================
+ Coverage 79.51% 79.54% +0.02%
==========================================
Files 397 397
Lines 32321 32322 +1
==========================================
+ Hits 25701 25709 +8
+ Misses 6620 6613 -7
Continue to review full report at Codecov.
|
to create a full list of sm_SUITE test cases that depend on other modules and should be skipped at big_tests/dynamic_domains.spec, we can disable modules one by one at big_tests/test.config and run sm_SUITE for a static config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only have minor comments.
50ad6bb
to
f1cb05c
Compare
This PR introduces dynamic domains support for
mod_stream_management
.Some tests in sm_SUITE are disabled for dynamic domains because they depend on another modules that do not support dynamic domains yet.