-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/docker #3183
Conversation
9a147d5
to
5b6ee31
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ae1fa69
to
07df7ca
Compare
90da35f
to
ef22b7a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
small_tests_23 / small_tests / 6748350 internal_mnesia / internal_mnesia / 6748350 small_tests_21_3 / small_tests / 6748350 small_tests_22 / small_tests / 6748350 dynamic_domains / pgsql_mnesia / 6748350 ldap_mnesia_21 / ldap_mnesia / 6748350 ldap_mnesia_22 / ldap_mnesia / 6748350 ldap_mnesia_23 / ldap_mnesia / 6748350 elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 6748350 pgsql_mnesia / pgsql_mnesia / 6748350 mssql_mnesia / odbc_mssql_mnesia / 6748350 mysql_redis / mysql_redis / 6748350 mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n [<<\"montague@montague.net\">>,\n <<\"romeo@montague.net\">>],\n []}\n\tValue {prefs_result_iq,<<\"always\">>,\n [<<\"montague@montague.net\">>,\n <<\"romeo@montague.net\">>],\n []}\n"}} riak_mnesia / riak_mnesia / 6748350 mod_ping_SUITE:server_ping:server_ping_pong{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
{expected_diff,5},
{before_story,0},
{after_story,4}}]},
[{escalus_mongooseim,post_story_check_metrics,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,74}]},
{escalus_mongooseim,maybe_check_metrics_post_story,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,51}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I like the cert check and removing unused files.
Do you think that the remaining jobs can be converted to use Docker as well?
All the others, totally, but they'll need to rework the whole ssl configuration and scripts with the pools, and that'll get quite more complex, so maybe for the future. |
In this PR I'm going to try to migrate at least some jobs to docker runners in CircleCI, like dialyzer, small_tests, and packages.
certs
preset in the main makefile now detects if the certificates are about to expire in the next hour, if so, they're deleted and recreated automatically..circleci/config.yml
Note that many jobs still run the old way, so this doesn't reduce the overall duration of CI. But some jobs are much faster:
otp_23
build job usually takes around 10min, whileotp_23_docker
takes 5-6min. On top of the later,small_tests_23
takes 8min anddialyzer
<2min, compared to the previous 11min and 13min on master