Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pull-db.sh #3207

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Remove pull-db.sh #3207

merged 2 commits into from
Aug 4, 2021

Conversation

arcusfelis
Copy link
Contributor

This PR addresses #

Proposed changes include:

  • describe the functionality changes
  • describe new or updated tests
  • describe changes to the documentation

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #3207 (91f42c8) into master (452ae97) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3207      +/-   ##
==========================================
- Coverage   80.29%   80.25%   -0.05%     
==========================================
  Files         397      397              
  Lines       32473    32473              
==========================================
- Hits        26073    26060      -13     
- Misses       6400     6413      +13     
Impacted Files Coverage Δ
src/mod_roster_mnesia.erl 72.72% <0.00%> (-21.22%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/mod_roster.erl 79.41% <0.00%> (-0.25%) ⬇️
src/mod_muc_room.erl 77.12% <0.00%> (-0.06%) ⬇️
src/ejabberd_c2s.erl 89.28% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452ae97...91f42c8. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 4, 2021

small_tests_24 / small_tests / f57f01a
Reports root / small


internal_mnesia_24 / internal_mnesia / f57f01a
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


small_tests_22 / small_tests / f57f01a
Reports root / small


dynamic_domains_24 / pgsql_mnesia / f57f01a
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / f57f01a
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_23 / small_tests / f57f01a
Reports root / small


ldap_mnesia_24 / ldap_mnesia / f57f01a
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / f57f01a
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f57f01a
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / f57f01a
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / f57f01a
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / f57f01a
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / f57f01a
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / f57f01a
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / f57f01a
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / f57f01a
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@NelsonVides
Copy link
Collaborator

Actually I just have a question, where is this used? A quick git grep doesn't show me any result 🤔

@arcusfelis
Copy link
Contributor Author

@NelsonVides in travis, lol.
Removed it...

@arcusfelis arcusfelis changed the title Use the correct container in pull-db.sh Remove pull-db.sh Aug 4, 2021
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Riiiiiight... 😆

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 4, 2021

small_tests_24 / small_tests / 91f42c8
Reports root / small


internal_mnesia_24 / internal_mnesia / 91f42c8
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 91f42c8
Reports root


small_tests_22 / small_tests / 91f42c8
Reports root / small


dynamic_domains_24 / pgsql_mnesia / 91f42c8
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 91f42c8
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 91f42c8
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


small_tests_23 / small_tests / 91f42c8
Reports root / small


ldap_mnesia_22 / ldap_mnesia / 91f42c8
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 91f42c8
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 91f42c8
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 91f42c8
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 91f42c8
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 91f42c8
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 91f42c8
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 91f42c8
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 91f42c8
Reports root/ big
OK: 1737 / Failed: 1 / User-skipped: 286 / Auto-skipped: 0

dynamic_domains_SUITE:with_mod_dynamic_domains_test:iq_handling_for_subdomain
{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"to">>,<<"subdomain2.example.test">>},
         {<<"type">>,<<"get">>},
         {<<"id">>,<<"03d9d8050dc3da6b590a9453e72f46e4">>}],
        [{xmlel,<<"query">>,[{<<"xmlns">>,<<"dummy.namespace">>}],[]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"subdomain2.example.test">>},
        {<<"to">>,<<"alice@example.com/res1">>},
        {<<"type">>,<<"error">>},
        {<<"xml:lang">>,<<"en">>},
        {<<"id">>,<<"03d9d8050dc3da6b590a9453e72f46e4">>}],
       [{xmlel,<<"query">>,[{<<"xmlns">>,<<"dummy.namespace">>}],[]},
        {xmlel,<<"error">>,
          [{<<"code">>,<<"404">>},{<<"type">>,<<"cancel">>}],
          [{xmlel,<<"remote-server-not-found">>,
             [{<<"xmlns">>,
             <<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
             []},
           {xmlel,<<"text">>,
             [{<<"xmlns">>,
             <<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
             [{xmlcdata,<<"From s2s (waiting)">>}]}]}]},
     "<iq from='subdomain2.example.test' to='alice@example.com/res1' type='error' xml:lang='en' id='03d9d8050dc3da6b590a9453e72f46e4'><query xmlns='dummy.namespace'/><error code='404' type='cancel'><remote-server-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/><text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>From s2s (waiting)</text></error></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib...

Report log


riak_mnesia_24 / riak_mnesia / 91f42c8
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

@NelsonVides NelsonVides merged commit fa5e5a2 into master Aug 4, 2021
@NelsonVides NelsonVides deleted the mu-fix-mssql-pull branch August 4, 2021 17:32
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants