-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that check_for_updates_tref is set #3225
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
==========================================
- Coverage 80.31% 80.29% -0.03%
==========================================
Files 398 398
Lines 32505 32507 +2
==========================================
- Hits 26108 26100 -8
- Misses 6397 6407 +10
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / a548249 internal_mnesia_24 / internal_mnesia / a548249 dynamic_domains_24 / pgsql_mnesia / a548249 small_tests_22 / small_tests / a548249 dynamic_domains_23 / pgsql_mnesia / a548249 small_tests_23 / small_tests / a548249 ldap_mnesia_22 / ldap_mnesia / a548249 ldap_mnesia_24 / ldap_mnesia / a548249 ldap_mnesia_23 / ldap_mnesia / a548249 pgsql_mnesia_24 / pgsql_mnesia / a548249 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a548249 pgsql_mnesia_22 / pgsql_mnesia / a548249 mssql_mnesia_24 / odbc_mssql_mnesia / a548249 pgsql_mnesia_23 / pgsql_mnesia / a548249 mysql_redis_24 / mysql_redis / a548249 riak_mnesia_24 / riak_mnesia / a548249 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a548249
to
5dd2c6e
Compare
small_tests_24 / small_tests / 5dd2c6e internal_mnesia_24 / internal_mnesia / 5dd2c6e dynamic_domains_24 / pgsql_mnesia / 5dd2c6e dynamic_domains_23 / pgsql_mnesia / 5dd2c6e small_tests_22 / small_tests / 5dd2c6e small_tests_23 / small_tests / 5dd2c6e ldap_mnesia_24 / ldap_mnesia / 5dd2c6e ldap_mnesia_22 / ldap_mnesia / 5dd2c6e elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5dd2c6e ldap_mnesia_23 / ldap_mnesia / 5dd2c6e pgsql_mnesia_22 / pgsql_mnesia / 5dd2c6e pgsql_mnesia_24 / pgsql_mnesia / 5dd2c6e mysql_redis_24 / mysql_redis / 5dd2c6e pgsql_mnesia_23 / pgsql_mnesia / 5dd2c6e mssql_mnesia_24 / odbc_mssql_mnesia / 5dd2c6e carboncopy_SUITE:all:prop_forward_received_chat_messages{error,
{{assertEqual,
[{module,carboncopy_SUITE},
{line,277},
{expression,
"proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
{expected,true},
{value,
[[{forward_received,
[{5,<<"Now, fair Hippolyta, our nuptial hour">>}]}]]}]},
[{carboncopy_SUITE,run_prop,2,
[{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
{line,277}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} carboncopy_SUITE:all:prop_forward_sent_chat_messages{error,
{{assertEqual,
[{module,carboncopy_SUITE},
{line,277},
{expression,
"proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
{expected,true},
{value,
[[{forward_sent,
[{5,<<"Now, fair Hippolyta, our nuptial hour">>}]}]]}]},
[{carboncopy_SUITE,run_prop,2,
[{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
{line,277}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} carboncopy_SUITE:all:prop_normal_routing_to_bare_jid{error,
{{assertEqual,
[{module,carboncopy_SUITE},
{line,277},
{expression,
"proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
{expected,true},
{value,
[[{normal_routing,
[{5,<<"Now, fair Hippolyta, our nuptial hour">>}]}]]}]},
[{carboncopy_SUITE,run_prop,2,
[{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
{line,277}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} inbox_SUITE:one_to_one:user_has_only_unread_messages_or_only_read{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bOb_user_has_only_unread_messages_or_only_read_13.525651@localhost/res1">>,
escalus_tcp,<0.18110.0>,
[{event_manager,<0.18053.0>},
{server,<<"localhost">>},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.18053.0>},
{server,<<"localhost">>},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"dbeb432d6e5962cb">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,get_inbox,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,219}]},
{escalus_story... riak_mnesia_24 / riak_mnesia / 5dd2c6e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load tested, it works correctly.
This PR addresses MIM-1472
Proposed changes include: