Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that check_for_updates_tref is set #3225

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

arcusfelis
Copy link
Contributor

This PR addresses MIM-1472

Proposed changes include:

  • Typo in check_for_updates_tref

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #3225 (5dd2c6e) into master (6d68ad1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3225      +/-   ##
==========================================
- Coverage   80.31%   80.29%   -0.03%     
==========================================
  Files         398      398              
  Lines       32505    32507       +2     
==========================================
- Hits        26108    26100       -8     
- Misses       6397     6407      +10     
Impacted Files Coverage Δ
src/domain/service_domain_db.erl 80.30% <100.00%> (+2.17%) ⬆️
src/mod_roster_riak.erl 81.53% <0.00%> (-15.39%) ⬇️
src/ejabberd_s2s_out.erl 60.82% <0.00%> (-1.14%) ⬇️
src/mod_muc.erl 74.88% <0.00%> (-0.23%) ⬇️
src/ejabberd_c2s.erl 89.20% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/mod_muc_room.erl 77.12% <0.00%> (ø)
src/inbox/mod_inbox_rdbms.erl 93.12% <0.00%> (+0.62%) ⬆️
src/rdbms/mongoose_rdbms.erl 61.69% <0.00%> (+0.80%) ⬆️
src/global_distrib/mod_global_distrib_utils.erl 65.42% <0.00%> (+0.93%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d68ad1...5dd2c6e. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 20, 2021

small_tests_24 / small_tests / a548249
Reports root / small


internal_mnesia_24 / internal_mnesia / a548249
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / a548249
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_22 / small_tests / a548249
Reports root / small


dynamic_domains_23 / pgsql_mnesia / a548249
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_23 / small_tests / a548249
Reports root / small


ldap_mnesia_22 / ldap_mnesia / a548249
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / a548249
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / a548249
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / a548249
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a548249
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / a548249
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / a548249
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / a548249
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / a548249
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / a548249
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 20, 2021

small_tests_24 / small_tests / 5dd2c6e
Reports root / small


internal_mnesia_24 / internal_mnesia / 5dd2c6e
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 5dd2c6e
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 5dd2c6e
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_22 / small_tests / 5dd2c6e
Reports root / small


small_tests_23 / small_tests / 5dd2c6e
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 5dd2c6e
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 5dd2c6e
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5dd2c6e
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 5dd2c6e
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 5dd2c6e
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 5dd2c6e
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 5dd2c6e
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 5dd2c6e
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 5dd2c6e
Reports root/ big
OK: 3113 / Failed: 4 / User-skipped: 184 / Auto-skipped: 0

carboncopy_SUITE:all:prop_forward_received_chat_messages
{error,
  {{assertEqual,
     [{module,carboncopy_SUITE},
      {line,277},
      {expression,
        "proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
      {expected,true},
      {value,
        [[{forward_received,
          [{5,<<"Now, fair Hippolyta, our nuptial hour">>}]}]]}]},
   [{carboncopy_SUITE,run_prop,2,
      [{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
       {line,277}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

carboncopy_SUITE:all:prop_forward_sent_chat_messages
{error,
  {{assertEqual,
     [{module,carboncopy_SUITE},
      {line,277},
      {expression,
        "proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
      {expected,true},
      {value,
        [[{forward_sent,
          [{5,<<"Now, fair Hippolyta, our nuptial hour">>}]}]]}]},
   [{carboncopy_SUITE,run_prop,2,
      [{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
       {line,277}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

carboncopy_SUITE:all:prop_normal_routing_to_bare_jid
{error,
  {{assertEqual,
     [{module,carboncopy_SUITE},
      {line,277},
      {expression,
        "proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
      {expected,true},
      {value,
        [[{normal_routing,
          [{5,<<"Now, fair Hippolyta, our nuptial hour">>}]}]]}]},
   [{carboncopy_SUITE,run_prop,2,
      [{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
       {line,277}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

inbox_SUITE:one_to_one:user_has_only_unread_messages_or_only_read
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_user_has_only_unread_messages_or_only_read_13.525651@localhost/res1">>,
          escalus_tcp,<0.18110.0>,
          [{event_manager,<0.18053.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18053.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_user_has_only_unread_messages_or_only_read_13.525651">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"dbeb432d6e5962cb">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,get_inbox,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,219}]},
     {escalus_story...

Report log


riak_mnesia_24 / riak_mnesia / 5dd2c6e
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Load tested, it works correctly.

@chrzaszcz chrzaszcz merged commit 2c223e0 into master Aug 20, 2021
@chrzaszcz chrzaszcz deleted the mu-fix-loader-tref branch August 20, 2021 13:14
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants