-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable metrics_register_SUITE for dynamic domains #3275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3275 +/- ##
==========================================
+ Coverage 80.19% 80.23% +0.04%
==========================================
Files 398 398
Lines 32560 32560
==========================================
+ Hits 26110 26125 +15
+ Misses 6450 6435 -15
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / ded53bd internal_mnesia_24 / internal_mnesia / ded53bd small_tests_22 / small_tests / ded53bd small_tests_23 / small_tests / ded53bd dynamic_domains_23 / pgsql_mnesia / ded53bd dynamic_domains_24 / pgsql_mnesia / ded53bd ldap_mnesia_22 / ldap_mnesia / ded53bd ldap_mnesia_24 / ldap_mnesia / ded53bd ldap_mnesia_23 / ldap_mnesia / ded53bd pgsql_mnesia_22 / pgsql_mnesia / ded53bd elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ded53bd pgsql_mnesia_24 / pgsql_mnesia / ded53bd pgsql_mnesia_23 / pgsql_mnesia / ded53bd mssql_mnesia_24 / odbc_mssql_mnesia / ded53bd inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910@localhost/res1">>,
escalus_tcp,<0.18365.0>,
[{event_manager,<0.18359.0>},
{server,<<"localhost">>},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.18359.0>},
{server,<<"localhost">>},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"fa67408a585f7a1b">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,mark_last_muclight_system_message,3,
[{file,"/home/circleci/app/big_test... mysql_redis_24 / mysql_redis / ded53bd mam_SUITE:rdbms_simple_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}} riak_mnesia_24 / riak_mnesia / ded53bd mssql_mnesia_24 / odbc_mssql_mnesia / ded53bd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but in init_per_testcase
there is code which checks config per domain, not per host type:
XMPPDomain = ct:get_config({hosts, mim, domain}), case rpc(mim(), ejabberd_config, get_local_option, [{auth_method, XMPPDomain}]) of
It does not affect the results because currently we are not using external
or anonymous
.
Enable metrics_register_SUITE for dynamic domains