Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XEP-0333 Docs #3424

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add XEP-0333 Docs #3424

merged 1 commit into from
Jul 26, 2022

Conversation

theowenyoung
Copy link
Contributor

This PR addresses #

Proposed changes include:

  • describe the functionality changes
  • describe new or updated tests
  • describe changes to the documentation

By

%%%-------------------------------------------------------------------
%%% @copyright (C) 2021, Erlang-Solutions
%%% @doc
%%% This module implements [XEP-0333: Chat Markers] helper functions
%%% @end
%%%-------------------------------------------------------------------
-module(mongoose_chat_markers).
-include("mongoose_ns.hrl").
-include_lib("exml/include/exml.hrl").
%% Markers
-export([has_chat_markers/1,
list_chat_markers/1,
chat_marker_names/0]).
-type id() :: binary().
-type chat_marker_type() :: received | displayed | acknowledged.
-type chat_marker_element() :: {chat_marker_type(), id()}.
-export_type([chat_marker_type/0]).

Does it seem the chat markers feature can list in the doc?

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good

@chrzaszcz chrzaszcz merged commit eb7dd31 into esl:master Jul 26, 2022
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants