Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick xref unneeded ignore #3440

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Quick xref unneeded ignore #3440

merged 2 commits into from
Dec 9, 2021

Conversation

NelsonVides
Copy link
Collaborator

Just removing dead ignore_xref's and code, low hanging fruit here 👌🏽

@NelsonVides NelsonVides force-pushed the quick_xref_unneeded_ignore branch from 0e193cc to 0f8dfc9 Compare December 9, 2021 14:24
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 9, 2021

small_tests_24 / small_tests / 0f8dfc9
Reports root / small


small_tests_23 / small_tests / 0f8dfc9
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 2754 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

sm_SUITE:parallel:messages_are_properly_flushed_during_resumption_p1_fsm_old
{error,
  {{badmatch,
     {error,
       {connection_step_failed,
         {#Fun<sm_SUITE.11.2813143>,
          {client,
            <<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1684@domain.example.com">>,
            escalus_tcp,<0.31620.1>,undefined,
            [{username,
               <<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1684">>},
             {server,<<"domain.example.com">>},
             {host,<<"localhost">>},
             {password,<<"matygrysa">>},
             {stream_management,true},
             {stream_id,<<"532e2f660e1b4c5f">>}]},
          [{compression,[<<"zlib">>]},
           {starttls,true},
           {stream_management,true},
           {advanced_message_processing,true},
           {client_state_indication,false},
           {sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
           {caps,undefined}]},
         {timeout,get_resumed}}}},
   [{sm_SUITE,
      '-messages_are_properly_flushed_during_resumption_p1_fsm_old/1-fun-1-',
      3,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,1270}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_ser...

Report log


dynamic_domains_mysql_redis_24 / mysql_redis / 0f8dfc9
Reports root/ big
OK: 2709 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 0f8dfc9
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 0f8dfc9
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 0f8dfc9
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0f8dfc9
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9
Reports root/ big
OK: 3148 / Failed: 0 / User-skipped: 195 / Auto-skipped: 50

mam_SUITE:rdbms_async_cache_mam_all:rsm_all:init_per_group
{'EXIT',{test_case_failed,"Respond size is 13, 15 is expected."}}

Report log


mysql_redis_24 / mysql_redis / 0f8dfc9
Reports root/ big
OK: 3108 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 0f8dfc9
Reports root/ big
OK: 1726 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0


small_tests_24 / small_tests / 0f8dfc9
Reports root / small


small_tests_23 / small_tests / 0f8dfc9
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / 0f8dfc9
Reports root/ big
OK: 2709 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 0f8dfc9
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 0f8dfc9
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 0f8dfc9
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0f8dfc9
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 0f8dfc9
Reports root/ big
OK: 3108 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 0f8dfc9
Reports root/ big
OK: 1726 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #3440 (0f8dfc9) into master (e1e1e08) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3440      +/-   ##
==========================================
+ Coverage   80.77%   80.83%   +0.05%     
==========================================
  Files         415      415              
  Lines       32318    32314       -4     
==========================================
+ Hits        26105    26121      +16     
+ Misses       6213     6193      -20     
Impacted Files Coverage Δ
src/inbox/mod_inbox_entries.erl 96.66% <ø> (ø)
src/inbox/mod_inbox_muclight.erl 100.00% <ø> (ø)
src/jlib.erl 91.66% <ø> (+2.13%) ⬆️
src/xmpp_router.erl 100.00% <ø> (ø)
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
src/ejabberd_c2s.erl 88.89% <0.00%> (-0.38%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/mod_muc_room.erl 77.26% <0.00%> (+0.17%) ⬆️
src/mod_roster.erl 78.75% <0.00%> (+0.23%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e1e08...0f8dfc9. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit af8715f into master Dec 9, 2021
@chrzaszcz chrzaszcz deleted the quick_xref_unneeded_ignore branch December 9, 2021 18:34
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants