-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick xref unneeded ignore #3440
Conversation
0e193cc
to
0f8dfc9
Compare
small_tests_24 / small_tests / 0f8dfc9 small_tests_23 / small_tests / 0f8dfc9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9 sm_SUITE:parallel:messages_are_properly_flushed_during_resumption_p1_fsm_old{error,
{{badmatch,
{error,
{connection_step_failed,
{#Fun<sm_SUITE.11.2813143>,
{client,
<<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1684@domain.example.com">>,
escalus_tcp,<0.31620.1>,undefined,
[{username,
<<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1684">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_management,true},
{stream_id,<<"532e2f660e1b4c5f">>}]},
[{compression,[<<"zlib">>]},
{starttls,true},
{stream_management,true},
{advanced_message_processing,true},
{client_state_indication,false},
{sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
{caps,undefined}]},
{timeout,get_resumed}}}},
[{sm_SUITE,
'-messages_are_properly_flushed_during_resumption_p1_fsm_old/1-fun-1-',
3,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,1270}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_ser... dynamic_domains_mysql_redis_24 / mysql_redis / 0f8dfc9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9 ldap_mnesia_23 / ldap_mnesia / 0f8dfc9 internal_mnesia_24 / internal_mnesia / 0f8dfc9 ldap_mnesia_24 / ldap_mnesia / 0f8dfc9 pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0f8dfc9 pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9 mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9 mam_SUITE:rdbms_async_cache_mam_all:rsm_all:init_per_group{'EXIT',{test_case_failed,"Respond size is 13, 15 is expected."}} mysql_redis_24 / mysql_redis / 0f8dfc9 riak_mnesia_24 / riak_mnesia / 0f8dfc9 small_tests_24 / small_tests / 0f8dfc9 small_tests_23 / small_tests / 0f8dfc9 dynamic_domains_mysql_redis_24 / mysql_redis / 0f8dfc9 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9 ldap_mnesia_24 / ldap_mnesia / 0f8dfc9 ldap_mnesia_23 / ldap_mnesia / 0f8dfc9 internal_mnesia_24 / internal_mnesia / 0f8dfc9 pgsql_mnesia_24 / pgsql_mnesia / 0f8dfc9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0f8dfc9 mysql_redis_24 / mysql_redis / 0f8dfc9 mssql_mnesia_24 / odbc_mssql_mnesia / 0f8dfc9 pgsql_mnesia_23 / pgsql_mnesia / 0f8dfc9 riak_mnesia_24 / riak_mnesia / 0f8dfc9 |
Codecov Report
@@ Coverage Diff @@
## master #3440 +/- ##
==========================================
+ Coverage 80.77% 80.83% +0.05%
==========================================
Files 415 415
Lines 32318 32314 -4
==========================================
+ Hits 26105 26121 +16
+ Misses 6213 6193 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just removing dead ignore_xref's and code, low hanging fruit here 👌🏽