Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inbox refactor tests #3452

Merged
merged 5 commits into from
Dec 14, 2021
Merged

Inbox refactor tests #3452

merged 5 commits into from
Dec 14, 2021

Conversation

NelsonVides
Copy link
Collaborator

Just cleaning up inbox tests to reuse code between inbox_SUITE and inbox_extensions_SUITE

@NelsonVides
Remove unused macros
f0b7e80
@NelsonVides
Extend big_tests wait_until with a validator
18cd4d8 
The same code was added to the equivalent in small_tests here:
1da8bee
@NelsonVides
Ensure the inbox before setting properties
ee19538 
This will be necessary if inbox inputs are made async, as then the
following operation, to set an inbox property, will found an inbox entry
not yet created.
@NelsonVides
Refactor test to reuse vars and ensure inboxes are correct
e2d6a29
@NelsonVides
Refactor inbox tests to reuse code across both inbox SUITEs
ce0a8f3
@codecov
Copy link

codecov bot commented Dec 13, 2021 •
edited
Loading

Codecov Report

Merging #3452 (ce0a8f3) into master (394ec28) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
- Coverage   80.85%   80.82%   -0.03%     
==========================================
  Files         415      415              
  Lines       32312    32312              
==========================================
- Hits        26125    26116       -9     
- Misses       6187     6196       +9
Impacted Files Coverage Δ
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 75.47% <0.00%> (-1.89%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/rdbms/mongoose_rdbms.erl 61.75% <0.00%> (-1.20%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/mod_muc_room.erl 77.09% <0.00%> (-0.18%) ⬇️
src/pubsub/mod_pubsub.erl 73.13% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/ejabberd_c2s.erl 89.41% <0.00%> (+0.22%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394ec28...ce0a8f3. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 13, 2021 •
edited
Loading

small_tests_24 / small_tests / ce0a8f3
Reports root / small

small_tests_23 / small_tests / ce0a8f3
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ce0a8f3
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ce0a8f3
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / ce0a8f3
Reports root/ big
OK: 2708 / Failed: 0 / User-skipped: 203 / Auto-skipped: 1

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ce0a8f3
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / ce0a8f3
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / ce0a8f3
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / ce0a8f3
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / ce0a8f3
Reports root/ big
OK: 3108 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ce0a8f3
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / ce0a8f3
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / ce0a8f3
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / ce0a8f3
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / ce0a8f3
Reports root/ big
OK: 1726 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / ce0a8f3
Reports root/ big
OK: 2709 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

@mongoose-im mongoose-im mentioned this pull request Dec 13, 2021
Closed
Premwoik
Premwoik approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

arcusfelis
arcusfelis approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arcusfelis arcusfelis merged commit 9850c10 into master Dec 14, 2021
@arcusfelis arcusfelis deleted the inbox_refactor_tests branch December 14, 2021 11:06
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Premwoik Premwoik Premwoik approved these changes

@arcusfelis arcusfelis arcusfelis approved these changes

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NelsonVides @mongoose-im @arcusfelis @Premwoik