-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth method defaults #3458
Auth method defaults #3458
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3458 +/- ##
==========================================
- Coverage 80.78% 80.77% -0.02%
==========================================
Files 415 415
Lines 32306 32303 -3
==========================================
- Hits 26100 26093 -7
- Misses 6206 6210 +4
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
dc71bb9
to
4813679
Compare
small_tests_24 / small_tests / 4813679 small_tests_23 / small_tests / 4813679 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 4813679 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4813679 dynamic_domains_mysql_redis_24 / mysql_redis / 4813679 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 4813679 ldap_mnesia_23 / ldap_mnesia / 4813679 ldap_mnesia_24 / ldap_mnesia / 4813679 internal_mnesia_24 / internal_mnesia / 4813679 pgsql_mnesia_23 / pgsql_mnesia / 4813679 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 4813679 pgsql_mnesia_24 / pgsql_mnesia / 4813679 mysql_redis_24 / mysql_redis / 4813679 mssql_mnesia_24 / odbc_mssql_mnesia / 4813679 riak_mnesia_24 / riak_mnesia / 4813679 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 👍🏽
Introduce default values for
auth
methods, so they are easier to test and to find in the code.The
undefined
values for LDAP are also included as defaults for consistency.