Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow delete_room in mod_muc_light_commands when equal occupants is true #3473

Closed
wants to merge 2 commits into from
Closed

allow delete_room in mod_muc_light_commands when equal occupants is true #3473

wants to merge 2 commits into from

Conversation

apontini
Copy link

This PR addresses #3472

Proposed changes include:

  • allowing members to delete muc_light rooms when equal_occupants is set to true
  • no tests updated
  • no doc updated

@apontini apontini changed the title fix delete_room in mod_muc_light_commands when equal occupants is true allow delete_room in mod_muc_light_commands when equal occupants is true Dec 23, 2021
chrzaszcz
chrzaszcz reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though members shouldn't be allowed to delete rooms, this PR seems to be an acceptable fix. We are focusing on the new GraphQL API now, where this issue won't be present anymore.

src/muc_light/mod_muc_light_commands.erl Outdated Show resolved Hide resolved
@apontini @chrzaszcz
Applied src/muc_light/mod_muc_light_commands.erl suggestion
f10477d 
Co-authored-by: Paweł Chrząszcz <pawel.chrzaszcz@erlang-solutions.com>
@apontini
Copy link
Author

Closing since it was merged with #3576

@apontini apontini closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apontini @chrzaszcz